linux-kernel - RE: [PATCH] ahci: add a boot option to enable promise ahci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1AF0FA078A5A3541A8A8019D26081C2E88DCE6D981@ptt-ex02.promise.com.tw>
Date:	Tue, 25 Sep 2012 13:40:23 +0800
From:	Tony Hung - PTT 洪瑞嶸 
	<tony.hung@...promise.com>
To:	Jeff Garzik <jgarzik@...ox.com>
CC:	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ahci: add a boot option to enable promise ahci

On 2012/9/25 11:05 AM, Jeff Garzik wrote:
>
> On 09/23/2012 10:34 PM, Tony Hung - PTT 洪瑞嶸 wrote:
>
> > linux-3.2.0/drivers/ata/ahci.c: In function 'hptiop_host_request_callback':
>
> > 
>
> > Use min_t(size_t, ...) to fix.

Correct this,
linux-3.2.0/drivers/ata/ahci.c: In function 'ahci_init_one':
Use variable promise_enable to disable RAID PCI controlled by original AHCI.
>
> > 
>
> > Signed-off-by: Tony Hung <tony.hung@...promise.com>
>
> > ---
>
> > 
>
> > diff --git a/linux-3.2.0/drivers/ata/ahci.c b/linux-3.2.0/drivers/ata/ahci.c
>
> > --- a/linux-3.2.0/drivers/ata/ahci.c    2012-08-29 13:40:26.046851693 +0800
>
> > +++ b/linux-3.2.0/drivers/ata/ahci.c  2012-08-30 17:23:10.207838960 +0800
>
> > @@ -430,6 +430,9 @@ static int marvell_enable = 1;
>
> >   module_param(marvell_enable, int, 0644);
>
> >   MODULE_PARM_DESC(marvell_enable, "Marvell SATA via AHCI (1 =
>
> > enabled)");
>
> > 
>
> > +static int promise_enable;
>
> > +module_param(promise_enable, int, 0644);
>
> > +MODULE_PARM_DESC(promise_enable, "Promise SATA via AHCI (1 =
>
> > +enabled)");
>
> > 
>
> >   static void ahci_pci_save_initial_config(struct pci_dev *pdev,
>
> >                                                struct ahci_host_priv *hpriv)
>
> > @@ -1049,6 +1052,16 @@ static int ahci_init_one(struct pci_dev
>
> >            if (pdev->vendor == PCI_VENDOR_ID_MARVELL && !marvell_enable)
>
> >                    return -ENODEV;
>
> > 
>
> > +        /*
>
> > +         * In RAID mode, Promise software RAID need to replace
>
> > +         * original AHCI module, but if AHCI driver build-in kernel,
>
> > +         * Promise AHCI module need a boot option to disable it
>
> > +         */
>
> > +        if (promise_enable &&
>
> > +            ((pdev->class >> 8) == PCI_CLASS_STORAGE_RAID) &&
>
> > +             (pdev->vendor == PCI_VENDOR_ID_ATI ||
>
> > +              pdev->vendor == PCI_VENDOR_ID_AMD))
>
> > +                return -ENODEV;
>
>  
>
> We need the patch for the Promise Software RAID driver, to accept this...
>
>  
>
>          Jeff 

Patch file is in attachment, and sorry for error descript.

Best wishes,
Tony Hung

Received: from mailgw.promise.com.tw (192.168.202.247) by
 exchange2007.promise.com.tw (192.168.202.107) with Microsoft SMTP Server id
 8.2.255.0; Tue, 25 Sep 2012 11:05:26 +0800
Received: from 209.85.216.177	by mailgw.tw.promise.com with Mail2000 ESMTP
 Server V6.00S(31771:1:AUTH_NONE)	(envelope-from <jgpobox@...il.com>); Tue, 25
 Sep 2012 11:05:21 +0800 (CST)
Received: by qcsu28 with SMTP id u28so1178870qcs.8        for
 <tony.hung@...promise.com>; Mon, 24 Sep 2012 20:05:21 -0700 (PDT)
Received: by 10.224.212.3 with SMTP id gq3mr36710286qab.52.1348542321829;
        Mon, 24 Sep 2012 20:05:21 -0700 (PDT)
Received: from bd.yyz.us ([2001:4830:1603:2:21c:c0ff:fe79:c8c2])        by
 mx.google.com with ESMTPS id ep8sm28126521qab.22.2012.09.24.20.05.20
        (version=TLSv1/SSLv3 cipher=OTHER);        Mon, 24 Sep 2012 20:05:20
 -0700 (PDT)
From: Jeff Garzik <jgarzik@...ox.com>
To: =?big5?B?VG9ueSBIdW5nIC0gUFRUIKx4t+fArw==?= <tony.hung@...promise.com>
CC: "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Sender: Jeff Garzik <jgpobox@...il.com>
Date: Tue, 25 Sep 2012 11:05:18 +0800
Subject: Re: [PATCH] ahci: add a boot option to enable promise ahci
Thread-Topic: [PATCH] ahci: add a boot option to enable promise ahci
Thread-Index: Ac2ayp08ZFK3Rvx7S4OVxhfaJ7liCw==
Message-ID: <50611F6E.8000607@...ox.com>
References:
 <1AF0FA078A5A3541A8A8019D26081C2E88DCE6D976@...-ex02.promise.com.tw>
In-Reply-To:
 <1AF0FA078A5A3541A8A8019D26081C2E88DCE6D976@...-ex02.promise.com.tw>
X-MS-Exchange-Organization-AuthSource: EXCHANGE2007.promise.com.tw
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120827
 Thunderbird/15.0
x-mailgates: (RBL:2,PASS,0.000000e+00)(SPF:2,PASS,Pass)(flag:1,RELAY:PAS
	S)(IPF:2,PASS)(bayesian:SCORE-38,0.00,2)(commtouch:PASS,1,str=0001.0A150
	205.50611F76.01BA,ss=1,re=0.000,fgs=0,2)(compute_score:HAM,2,0)
dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed;        d=gmail.com;
 s=20120113;
        h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject
         :references:in-reply-to:content-type:content-transfer-encoding;
        bh=TB3HuWKUWBqMmZ//BOiMyW+EwzqBq41SN7mHdi6iZGM=;
        b=pJ/b1lbCzmk05CXDJuZPr6rBcYUKSfv+ZiCFK575Kxw/Eps1EdX1Ly+h85cnks8ArX
         Z2Cr64g2EApuXd4/tJuoVP0M/Ydp83UzwYiP57poFS5SgwzWfvgCsscfRHTCmlTF0rlD
         /35m3NVx1eTPgs5rkHq0r1KQUY6TTkJtCaCMHtn3OPCJHvGZye/kEv8PhrKZcThmwkPv
         IviwnvCRR2ddPkBZ/pvwpZ1dgW45vz+YYtw24V7ZJrrrlS8Wp414JPn+dqXpa7aN0qz5
         l0h7W/9useZPzWdmVVk86RKw7v9F/o+42oiO63dDrbKMtXFiFwZ8MOUVSh0bJPRAZsE5
         K75Q==
Content-Type: text/plain; charset="big5"
Content-Transfer-Encoding: base64
MIME-Version: 1.0

T24gMDkvMjMvMjAxMiAxMDozNCBQTSwgVG9ueSBIdW5nIC0gUFRUIKx4t+fAryB3cm90ZToNCj4g
bGludXgtMy4yLjAvZHJpdmVycy9hdGEvYWhjaS5jOiBJbiBmdW5jdGlvbiAnaHB0aW9wX2hvc3Rf
cmVxdWVzdF9jYWxsYmFjayc6DQo+DQo+IFVzZSBtaW5fdChzaXplX3QsIC4uLikgdG8gZml4Lg0K
Pg0KPiBTaWduZWQtb2ZmLWJ5OiBUb255IEh1bmcgPHRvbnkuaHVuZ0B0dy5wcm9taXNlLmNvbT4N
Cj4gLS0tDQo+DQo+IGRpZmYgLS1naXQgYS9saW51eC0zLjIuMC9kcml2ZXJzL2F0YS9haGNpLmMg
Yi9saW51eC0zLjIuMC9kcml2ZXJzL2F0YS9haGNpLmMNCj4gLS0tIGEvbGludXgtMy4yLjAvZHJp
dmVycy9hdGEvYWhjaS5jICAyMDEyLTA4LTI5IDEzOjQwOjI2LjA0Njg1MTY5MyArMDgwMA0KPiAr
KysgYi9saW51eC0zLjIuMC9kcml2ZXJzL2F0YS9haGNpLmMgIDIwMTItMDgtMzAgMTc6MjM6MTAu
MjA3ODM4OTYwICswODAwDQo+IEBAIC00MzAsNiArNDMwLDkgQEAgc3RhdGljIGludCBtYXJ2ZWxs
X2VuYWJsZSA9IDE7DQo+ICAgbW9kdWxlX3BhcmFtKG1hcnZlbGxfZW5hYmxlLCBpbnQsIDA2NDQp
Ow0KPiAgIE1PRFVMRV9QQVJNX0RFU0MobWFydmVsbF9lbmFibGUsICJNYXJ2ZWxsIFNBVEEgdmlh
IEFIQ0kgKDEgPSBlbmFibGVkKSIpOw0KPg0KPiArc3RhdGljIGludCBwcm9taXNlX2VuYWJsZTsN
Cj4gK21vZHVsZV9wYXJhbShwcm9taXNlX2VuYWJsZSwgaW50LCAwNjQ0KTsNCj4gK01PRFVMRV9Q
QVJNX0RFU0MocHJvbWlzZV9lbmFibGUsICJQcm9taXNlIFNBVEEgdmlhIEFIQ0kgKDEgPSBlbmFi
bGVkKSIpOw0KPg0KPiAgIHN0YXRpYyB2b2lkIGFoY2lfcGNpX3NhdmVfaW5pdGlhbF9jb25maWco
c3RydWN0IHBjaV9kZXYgKnBkZXYsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgIHN0cnVjdCBhaGNpX2hvc3RfcHJpdiAqaHByaXYpDQo+IEBAIC0xMDQ5LDYgKzEwNTIs
MTYgQEAgc3RhdGljIGludCBhaGNpX2luaXRfb25lKHN0cnVjdCBwY2lfZGV2DQo+ICAgICAgIGlm
IChwZGV2LT52ZW5kb3IgPT0gUENJX1ZFTkRPUl9JRF9NQVJWRUxMICYmICFtYXJ2ZWxsX2VuYWJs
ZSkNCj4gICAgICAgICAgICAgICByZXR1cm4gLUVOT0RFVjsNCj4NCj4gKyAgICAgICAgLyoNCj4g
KyAgICAgICAgICogSW4gUkFJRCBtb2RlLCBQcm9taXNlIHNvZnR3YXJlIFJBSUQgbmVlZCB0byBy
ZXBsYWNlDQo+ICsgICAgICAgICAqIG9yaWdpbmFsIEFIQ0kgbW9kdWxlLCBidXQgaWYgQUhDSSBk
cml2ZXIgYnVpbGQtaW4ga2VybmVsLA0KPiArICAgICAgICAgKiBQcm9taXNlIEFIQ0kgbW9kdWxl
IG5lZWQgYSBib290IG9wdGlvbiB0byBkaXNhYmxlIGl0DQo+ICsgICAgICAgICAqLw0KPiArICAg
ICAgICBpZiAocHJvbWlzZV9lbmFibGUgJiYNCj4gKyAgICAgICAgICAgICgocGRldi0+Y2xhc3Mg
Pj4gOCkgPT0gUENJX0NMQVNTX1NUT1JBR0VfUkFJRCkgJiYNCj4gKyAgICAgICAgICAgICAocGRl
di0+dmVuZG9yID09IFBDSV9WRU5ET1JfSURfQVRJIHx8DQo+ICsgICAgICAgICAgICAgIHBkZXYt
PnZlbmRvciA9PSBQQ0lfVkVORE9SX0lEX0FNRCkpDQo+ICsgICAgICAgICAgICAgICAgcmV0dXJu
IC1FTk9ERVY7DQoNCldlIG5lZWQgdGhlIHBhdGNoIGZvciB0aGUgUHJvbWlzZSBTb2Z0d2FyZSBS
QUlEIGRyaXZlciwgdG8gYWNjZXB0IHRoaXMuLi4NCg0KICAgICAgICBKZWZmDQoNCg0KDQoNCg==