Message-ID: <1348662131.24309.74.camel@sauron.fi.intel.com>
Date:	Wed, 26 Sep 2012 15:22:11 +0300
From:	Artem Bityutskiy <artem.bityutskiy@...ux.intel.com>
To:	Richard Weinberger <richard@....at>
Cc:	linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org,
	tglx@...utronix.de, Heinz.Egger@...utronix.de, tim.bird@...sony.com
Subject: Re: UBI: Fastmap request for inclusion (v18)

On Mon, 2012-09-24 at 20:31 +0200, Richard Weinberger wrote:
> UBI Fastmap is an optional feature which stores the physical to
> logical eraseblock relations in a checkpoint (called fastmap) to reduce
> the initialization time of UBI. The current init time of UBI is
> proportional to the number of physical erase blocks on the FLASH
> device. With fastmap enabled the scan time is limited to a fixed
> number of blocks.

Aiaiai!

Please, take a look at Aiaiai's complaints below. I did not go through
them myself.

dedekind@...e:~/git/maintaining$ ../aiaiai/aiaiai-concat-mboxes ~/tmp/richard* | ./verify ../linux-ubi gen
Tested the patch(es) on top of the following commits:
311a256 Quick fixes - applied by aiaiai
55393ba UBI: fix trivial typo 'it' => 'is'
cf38aca UBI: load after mtd device drivers
719bb84 UBI: print less

--------------------------------------------------------------------------------

Bisectability test results for configuration "arm-omap2plus_defconfig,arm,arm-unknown-linux-gnueabi-"

Failed to build the following commit for configuration "arm-omap2plus_defconfig"":

cabfa2b UBI: Add fastmap stuff to ubi.h


drivers/mtd/ubi/attach.c: In function 'scan_all':
drivers/mtd/ubi/attach.c:1220:2: error: implicit declaration of function 'ubi_destroy_ai' [-Werror=implicit-function-declaration]
drivers/mtd/ubi/attach.c: At top level:
drivers/mtd/ubi/attach.c:1231:5: error: conflicting types for 'ubi_attach'
drivers/mtd/ubi/ubi.h:713:5: note: previous declaration of 'ubi_attach' was here
drivers/mtd/ubi/attach.c:1309:6: warning: no previous prototype for 'ubi_destroy_ai' [-Wmissing-prototypes]
drivers/mtd/ubi/attach.c:1309:6: warning: conflicting types for 'ubi_destroy_ai' [enabled by default]
drivers/mtd/ubi/attach.c:1220:2: note: previous implicit declaration of 'ubi_destroy_ai' was here
cc1: some warnings being treated as errors
make[4]: *** [drivers/mtd/ubi/attach.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "arm-omap2plus_defconfig,arm,arm-unknown-linux-gnueabi-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function 'ubi_attach':
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter 'force_scan' set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
+drivers/mtd/ubi/wl.c:363:27: warning: variable 'prev_e' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function 'wear_leveling_worker':
+drivers/mtd/ubi/wl.c:998:6: warning: variable 'anchor' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "i386_defconfig,i386,"

Failed to build the following commit for configuration "i386_defconfig"":

258cfe8 UBI: Add fastmap stuff to ubi.h


drivers/mtd/ubi/build.c: In function ‘ubi_attach_mtd_dev’:
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function ‘ubi_attach’
In file included from drivers/mtd/ubi/build.c:44:0:
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "i386_defconfig,i386,", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function ‘ubi_attach’:
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter ‘force_scan’ set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function ‘find_wl_entry’:
+drivers/mtd/ubi/wl.c:363:27: warning: variable ‘prev_e’ set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function ‘wear_leveling_worker’:
+drivers/mtd/ubi/wl.c:998:6: warning: variable ‘anchor’ set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "ia64_defconfig,ia64,ia64-linux-"

Failed to build the following commit for configuration "ia64_defconfig"":

f1b826b UBI: Add fastmap stuff to ubi.h


warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
warning: (IA64) selects PM which has unmet direct dependencies (PM_SLEEP || PM_RUNTIME)
kernel/sys.c: In function 'sys_prctl':
kernel/sys.c:2026:4: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
kernel/module.c: In function 'add_usage_links':
kernel/module.c:1484:6: warning: variable 'nowarn' set but not used [-Wunused-but-set-variable]
kernel/module.c: At top level:
kernel/module.c:3531:6: warning: no previous prototype for 'module_layout' [-Wmissing-prototypes]
drivers/mtd/ubi/build.c: In function 'ubi_attach_mtd_dev':
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function 'ubi_attach'
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "ia64_defconfig,ia64,ia64-linux-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function 'ubi_attach':
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter 'force_scan' set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
+drivers/mtd/ubi/wl.c:363:27: warning: variable 'prev_e' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function 'wear_leveling_worker':
+drivers/mtd/ubi/wl.c:998:6: warning: variable 'anchor' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "m68k-m5208evb_defconfig,m68k,m68k-linux-"

Failed to build the following commit for configuration "m68k-m5208evb_defconfig"":

638c620 UBI: Add fastmap stuff to ubi.h


kernel/sys.c: In function 'sys_prctl':
kernel/sys.c:2026:4: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
drivers/mtd/ubi/build.c: In function 'ubi_attach_mtd_dev':
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function 'ubi_attach'
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "m68k-m5208evb_defconfig,m68k,m68k-linux-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function 'ubi_attach':
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter 'force_scan' set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
+drivers/mtd/ubi/wl.c:363:27: warning: variable 'prev_e' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function 'wear_leveling_worker':
+drivers/mtd/ubi/wl.c:998:6: warning: variable 'anchor' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "mips64_defconfig,mips,mips64-linux-"

Failed to build the following commit for configuration "mips64_defconfig"":

d5665b7 UBI: Add fastmap stuff to ubi.h

kernel/sys.c:1365:1: warning: no previous prototype for 'SyS_sethostname' [-Wmissing-prototypes]
kernel/sys.c:1391:1: warning: no previous prototype for 'SyS_gethostname' [-Wmissing-prototypes]
kernel/sys.c:1416:1: warning: no previous prototype for 'SyS_setdomainname' [-Wmissing-prototypes]
kernel/sys.c:1440:1: warning: no previous prototype for 'SyS_getrlimit' [-Wmissing-prototypes]
kernel/sys.c:1459:1: warning: no previous prototype for 'SyS_old_getrlimit' [-Wmissing-prototypes]
kernel/sys.c:1601:1: warning: no previous prototype for 'SyS_prlimit64' [-Wmissing-prototypes]
kernel/sys.c:1641:1: warning: no previous prototype for 'SyS_setrlimit' [-Wmissing-prototypes]
kernel/sys.c:1774:1: warning: no previous prototype for 'SyS_getrusage' [-Wmissing-prototypes]
kernel/sys.c:1782:1: warning: no previous prototype for 'SyS_umask' [-Wmissing-prototypes]
kernel/sys.c:2000:1: warning: no previous prototype for 'SyS_prctl' [-Wmissing-prototypes]
kernel/sys.c: In function 'SYSC_prctl':
kernel/sys.c:2026:4: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
kernel/sys.c: At top level:
kernel/sys.c:2171:1: warning: no previous prototype for 'SyS_getcpu' [-Wmissing-prototypes]
kernel/module.c:769:1: warning: no previous prototype for 'SyS_delete_module' [-Wmissing-prototypes]
kernel/module.c: In function 'add_usage_links':
kernel/module.c:1484:6: warning: variable 'nowarn' set but not used [-Wunused-but-set-variable]
kernel/module.c: At top level:
kernel/module.c:3011:1: warning: no previous prototype for 'SyS_init_module' [-Wmissing-prototypes]
kernel/module.c:3531:6: warning: no previous prototype for 'module_layout' [-Wmissing-prototypes]
drivers/mtd/ubi/build.c: In function 'ubi_attach_mtd_dev':
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function 'ubi_attach'
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "mips64_defconfig,mips,mips64-linux-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function 'ubi_attach':
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter 'force_scan' set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
+drivers/mtd/ubi/wl.c:363:27: warning: variable 'prev_e' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function 'wear_leveling_worker':
+drivers/mtd/ubi/wl.c:998:6: warning: variable 'anchor' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "mips-bcm63xx_defconfig,mips,mips-linux-"

Failed to build the following commit for configuration "mips-bcm63xx_defconfig"":

aef58e8 UBI: Add fastmap stuff to ubi.h


drivers/mtd/ubi/build.c: In function 'ubi_attach_mtd_dev':
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function 'ubi_attach'
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "mips-bcm63xx_defconfig,mips,mips-linux-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function 'ubi_attach':
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter 'force_scan' set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
+drivers/mtd/ubi/wl.c:363:27: warning: variable 'prev_e' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function 'wear_leveling_worker':
+drivers/mtd/ubi/wl.c:998:6: warning: variable 'anchor' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "ppc32_defconfig,powerpc,powerpc-linux-"

Failed to build the following commit for configuration "ppc32_defconfig"":

18ae4d4 UBI: Add fastmap stuff to ubi.h


warning: (MPC836x_RDK && MTD_NAND_FSL_ELBC && MTD_NAND_FSL_UPM) selects FSL_LBC which has unmet direct dependencies (FSL_SOC)
warning: (MPC836x_RDK && MTD_NAND_FSL_ELBC && MTD_NAND_FSL_UPM) selects FSL_LBC which has unmet direct dependencies (FSL_SOC)
warning: (MPC836x_RDK && MTD_NAND_FSL_ELBC && MTD_NAND_FSL_UPM) selects FSL_LBC which has unmet direct dependencies (FSL_SOC)
drivers/mtd/ubi/build.c: In function 'ubi_attach_mtd_dev':
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function 'ubi_attach'
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "ppc32_defconfig,powerpc,powerpc-linux-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function 'ubi_attach':
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter 'force_scan' set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
+drivers/mtd/ubi/wl.c:363:27: warning: variable 'prev_e' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function 'wear_leveling_worker':
+drivers/mtd/ubi/wl.c:998:6: warning: variable 'anchor' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "ppc64_defconfig,powerpc,powerpc64-linux-"

Failed to build the following commit for configuration "ppc64_defconfig"":

d1ad70b UBI: Add fastmap stuff to ubi.h


warning: (MPC836x_RDK && MTD_NAND_FSL_ELBC && MTD_NAND_FSL_UPM) selects FSL_LBC which has unmet direct dependencies (FSL_SOC)
warning: (MPC836x_RDK && MTD_NAND_FSL_ELBC && MTD_NAND_FSL_UPM) selects FSL_LBC which has unmet direct dependencies (FSL_SOC)
warning: (MPC836x_RDK && MTD_NAND_FSL_ELBC && MTD_NAND_FSL_UPM) selects FSL_LBC which has unmet direct dependencies (FSL_SOC)
drivers/mtd/ubi/build.c: In function 'ubi_attach_mtd_dev':
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function 'ubi_attach'
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "ppc64_defconfig,powerpc,powerpc64-linux-", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function 'ubi_attach':
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter 'force_scan' set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function 'find_wl_entry':
+drivers/mtd/ubi/wl.c:363:27: warning: variable 'prev_e' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function 'wear_leveling_worker':
+drivers/mtd/ubi/wl.c:998:6: warning: variable 'anchor' set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

Bisectability test results for configuration "x86_64_defconfig,x86_64,"

Failed to build the following commit for configuration "x86_64_defconfig"":

9d3e659 UBI: Add fastmap stuff to ubi.h


drivers/mtd/ubi/build.c: In function ‘ubi_attach_mtd_dev’:
drivers/mtd/ubi/build.c:941:2: error: too few arguments to function ‘ubi_attach’
In file included from drivers/mtd/ubi/build.c:44:0:
drivers/mtd/ubi/ubi.h:713:5: note: declared here
make[4]: *** [drivers/mtd/ubi/build.o] Error 1

--------------------------------------------------------------------------------

Successfully built configuration "x86_64_defconfig,x86_64,", results:

--- before_patching.log
+++ after_patching.log
@@ @@
+drivers/mtd/ubi/attach.c: In function ‘ubi_attach’:
+drivers/mtd/ubi/attach.c:1400:44: warning: parameter ‘force_scan’ set but not used [-Wunused-but-set-parameter]
@@ @@
+drivers/mtd/ubi/eba.c:1260:2-11: alloc with no test, possible model on line 1270 [coccinelle]
@@ @@
+drivers/mtd/ubi/wl.c: In function ‘find_wl_entry’:
+drivers/mtd/ubi/wl.c:363:27: warning: variable ‘prev_e’ set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c: In function ‘wear_leveling_worker’:
+drivers/mtd/ubi/wl.c:998:6: warning: variable ‘anchor’ set but not used [-Wunused-but-set-variable]
+drivers/mtd/ubi/wl.c:284:3-9: preceding lock on line 282 [coccinelle]

--------------------------------------------------------------------------------

checkpatch.pl has some complaints:

--------------------------------------------------------------------------------

checkpatch.pl results for patch "[PATCH 05/10] UBI: Add fastmap bits to build.c"

WARNING:SPLIT_STRING: quoted string split across lines
#151: FILE: drivers/mtd/ubi/build.c:1469:
+MODULE_PARM_DESC(fm_autoconvert, "Set this parameter to enable fastmap "
+                                "automatically on images without a fastmap.");

total: 0 errors, 1 warnings, 133 lines checked

--------------------------------------------------------------------------------

checkpatch.pl results for patch "[PATCH 07/10] UBI: Add fastmap stuff to attach.c"

WARNING:SPLIT_STRING: quoted string split across lines
#113: FILE: drivers/mtd/ubi/attach.c:1009:
+                               ubi_msg("\"delete\" compatible internal volume"
+                                       " %d:%d found, will remove it",

total: 0 errors, 1 warnings, 535 lines checked

--------------------------------------------------------------------------------

checkpatch.pl results for the entire squashed patch-set

WARNING:SPLIT_STRING: quoted string split across lines
#794: FILE: drivers/mtd/ubi/build.c:1469:
+MODULE_PARM_DESC(fm_autoconvert, "Set this parameter to enable fastmap "
+                                "automatically on images without a fastmap.");

WARNING:SPLIT_STRING: quoted string split across lines
#996: FILE: drivers/mtd/ubi/attach.c:1009:
+                               ubi_msg("\"delete\" compatible internal volume"
+                                       " %d:%d found, will remove it",

total: 0 errors, 2 warnings, 3712 lines checked

--------------------------------------------------------------------------------

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)

Powered by blists - more mailing lists