linux-kernel - Re: [PATCH] x86: remove the useless branch in c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120926130257.GH17345@aftab.osrc.amd.com>
Date:	Wed, 26 Sep 2012 15:02:57 +0200
From:	Borislav Petkov <bp@...64.org>
To:	Michael Wang <wangyun@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	kjwinchester@...il.com, ak@...ux.intel.com, hpa@...or.com,
	mingo@...hat.com, tglx@...utronix.de
Subject: Re: [PATCH] x86: remove the useless branch in c_start()

On Wed, Sep 26, 2012 at 11:43:52AM +0800, Michael Wang wrote:
> On 09/19/2012 01:42 PM, Michael Wang wrote:
> > Since 'cpu == -1' in cpumask_next() is legal, no need to handle '*pos == 0'
> > specially.
> > 
> > About the comments:
> > 	/* just in case, cpu 0 is not the first */
> > A test with a cpumask in which cpu 0 is not the first has been done, and it
> > works well.
> 
> Could I get some comments on this patch?

Looks ok to me:

Acked-by: Borislav Petkov <borislav.petkov@....com>

Thanks.

-- 
Regards/Gruss,
Boris.

Advanced Micro Devices GmbH
Einsteinring 24, 85609 Dornach
GM: Alberto Bozzo
Reg: Dornach, Landkreis Muenchen
HRB Nr. 43632 WEEE Registernr: 129 19551
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/