linux-kernel - RE: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 26 Sep 2012 13:44:12 +0000
From:	"Karicheri, Muralidharan" <m-karicheri2@...com>
To:	Linus Walleij <linus.walleij@...aro.org>
CC:	"mturquette@...aro.org" <mturquette@...aro.org>,
	"arnd@...db.de" <arnd@...db.de>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	"shawn.guo@...aro.org" <shawn.guo@...aro.org>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"viresh.linux@...il.com" <viresh.linux@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Nori, Sekhar" <nsekhar@...com>, "Hilman, Kevin" <khilman@...com>,
	"linux@....linux.org.uk" <linux@....linux.org.uk>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-keystone@...t.ti.com - Linux developers for Keystone family of
	devices (May contain non-TIers)" <linux-keystone@...t.ti.com>,
	"linux-c6x-dev@...ux-c6x.org" <linux-c6x-dev@...ux-c6x.org>,
	"Chemparathy, Cyril" <cyril@...com>
Subject: RE: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci - add Main
 PLL clock driver

>> -----Original Message-----
>> From: Linus Walleij [mailto:linus.walleij@...aro.org]
>> Sent: Wednesday, September 26, 2012 7:11 AM
>> To: Karicheri, Muralidharan
>> Cc: mturquette@...aro.org; arnd@...db.de; akpm@...ux-foundation.org;
>> shawn.guo@...aro.org; rob.herring@...xeda.com; viresh.linux@...il.com; linux-
>> kernel@...r.kernel.org; Nori, Sekhar; Hilman, Kevin; linux@....linux.org.uk; davinci-
>> linux-open-source@...ux.davincidsp.com; linux-arm-kernel@...ts.infradead.org; linux-
>> keystone@...t.ti.com - Linux developers for Keystone family of devices (May contain non-
>> TIers); linux-c6x-dev@...ux-c6x.org; Chemparathy, Cyril
>> Subject: [linux-keystone] Re: [PATCH v1 01/12] clk: davinci - add Main PLL clock driver
>> 
>> On Tue, Sep 25, 2012 at 12:20 AM, Murali Karicheri <m-karicheri2@...com> wrote:
>> 
>> > +struct clk_davinci_pll_data {
>> > +       /* physical addresses set by platform code */
>> > +       u32 phy_pllm;
>> > +       /* if PLL has a prediv register this should be non zero */
>> > +       u32 phy_prediv;
>> > +       /* if PLL has a postdiv register this should be non zero */
>> > +       u32 phy_postdiv;
>> > +       /* mapped addresses. should be initialized by  */
>> > +       void __iomem *pllm;
>> > +       void __iomem *prediv;
>> > +       void __iomem *postdiv;
>> > +       u32 pllm_mask;
>> > +       u32 prediv_mask;
>> > +       u32 postdiv_mask;
>> > +       u32 num;
>> > +       /* framework flags */
>> > +       u32 flags;
>> > +       /* pll flags */
>> > +       u32 pll_flags;
>> > +       u32 fixed_prediv;       /* use this value for prediv */
>> > +       u32 pllm_multiplier;    /* multiply PLLM by this factor. By default
>> > +                                * most SOC set this to zero that translates
>> > +                                * to a multiplier of 1 and incrementer of 1.
>> > +                                * To override default, set this factor */
>> > +};
>> 
>> OMG this commenting style hurt my eyes ;-)
>> 
>> Please use good old kerneldoc above the struct instead.
>> 
>> Yours,
>> Linus Walleij

Sure! I will fix these in my next revision.

Murali
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/