linux-kernel - Re: [PATCH 1/8] sta2x11-mfd : add apb-soc regs driver and factor out common code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120926145615.GJ10147@mail.gnudd.com>
Date:	Wed, 26 Sep 2012 16:56:15 +0200
From:	Davide Ciminaghi <ciminaghi@...dd.com>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Cc:	sameo@...ux.intel.com, rubini@...dd.com, giancarlo.asnaghi@...com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] sta2x11-mfd : add apb-soc regs driver and factor out common code

On Tue, Sep 25, 2012 at 08:20:48PM +0100, Mark Brown wrote:
> On Wed, Sep 12, 2012 at 12:22:47PM +0200, ciminaghi@...dd.com wrote:
> > From: Davide Ciminaghi <ciminaghi@...dd.com>
> > 
> > A driver for the apb-soc registers is needed by the clock
> > infrastructure code to configure and control clocks on the sta2x11
> > chip.
> > Since some of the functions in sta2x11-mfd.c were almost identical
> > for the two existing platform devices, the following changes
> > have been performed to avoid further code duplication while
> > adding the apb-soc-regs driver:
> 
> Glancing at the diff here this looks a lot like regmap-mmio...  not sure
> if it is or not, though.

that would be ideal, but I also need to deal with the common clock framework,
which doesn't support regmap: clk_register_divider(), clk_register_mux(),
clk_register_gate(), all take a void __iomem * to access clock control
registers, so as far as I can understand we can't use regmap, unless of
course we convert the common clock framework to regmap.

Thanks
Davide
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/