lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Sep 2012 18:01:27 +0200 From: Michal Hocko <mhocko@...e.cz> To: Glauber Costa <glommer@...allels.com> Cc: linux-kernel@...r.kernel.org, cgroups@...r.kernel.org, kamezawa.hiroyu@...fujitsu.com, devel@...nvz.org, Tejun Heo <tj@...nel.org>, linux-mm@...ck.org, Suleiman Souhlal <suleiman@...gle.com>, Frederic Weisbecker <fweisbec@...il.com>, Mel Gorman <mgorman@...e.de>, David Rientjes <rientjes@...gle.com>, Johannes Weiner <hannes@...xchg.org> Subject: Re: [PATCH v3 04/13] kmem accounting basic infrastructure On Wed 26-09-12 18:33:10, Glauber Costa wrote: > On 09/26/2012 06:03 PM, Michal Hocko wrote: > > On Tue 18-09-12 18:04:01, Glauber Costa wrote: [...] > >> @@ -4961,6 +5015,12 @@ mem_cgroup_create(struct cgroup *cont) > >> int cpu; > >> enable_swap_cgroup(); > >> parent = NULL; > >> + > >> +#ifdef CONFIG_MEMCG_KMEM > >> + WARN_ON(cgroup_add_cftypes(&mem_cgroup_subsys, > >> + kmem_cgroup_files)); > >> +#endif > >> + > >> if (mem_cgroup_soft_limit_tree_init()) > >> goto free_out; > >> root_mem_cgroup = memcg; > >> @@ -4979,6 +5039,7 @@ mem_cgroup_create(struct cgroup *cont) > >> if (parent && parent->use_hierarchy) { > >> res_counter_init(&memcg->res, &parent->res); > >> res_counter_init(&memcg->memsw, &parent->memsw); > >> + res_counter_init(&memcg->kmem, &parent->kmem); > > > > Haven't we already discussed that a new memcg should inherit kmem_accounted > > from its parent for use_hierarchy? > > Say we have > > root > > | > > A (kmem_accounted = 1, use_hierachy = 1) > > \ > > B (kmem_accounted = 0) > > \ > > C (kmem_accounted = 1) > > > > B find's itself in an awkward situation becuase it doesn't want to > > account u+k but it ends up doing so becuase C. > > > > Ok, I haven't updated it here. But that should be taken care of in the > lifecycle patch. I am not sure which patch you are thinking about but I would prefer to have it here because it is safe wrt. races and it is more obvious as well. -- Michal Hocko SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists