lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Sep 2012 22:28:29 +0530 From: Pankaj Jangra <jangra.pankaj9@...il.com> To: Stephen Boyd <sboyd@...eaurora.org> Cc: David Brown <davidb@...eaurora.org>, Daniel Walker <dwalker@...o99.com>, Bryan Huntsman <bryanh@...eaurora.org>, linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, linux-usb@...r.kernel.org, Felipe Balbi <balbi@...com> Subject: Re: [PATCH 01/10] usb: otg: msm: Convert to clk_prepare/unprepare Hi.. On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@...eaurora.org> wrote: > Add calls to clk_prepare and unprepare so that MSM can migrate to > the common clock framework. > > Cc: Felipe Balbi <balbi@...com> > Signed-off-by: Stephen Boyd <sboyd@...eaurora.org> > --- > drivers/usb/otg/msm_otg.c | 38 +++++++++++++++++++------------------- > 1 file changed, 19 insertions(+), 19 deletions(-) > > diff --git a/drivers/usb/otg/msm_otg.c b/drivers/usb/otg/msm_otg.c > index 9f5fc90..2ae0639 100644 > --- a/drivers/usb/otg/msm_otg.c > +++ b/drivers/usb/otg/msm_otg.c > @@ -514,13 +514,13 @@ static int msm_otg_suspend(struct msm_otg *motg) > motg->pdata->otg_control == OTG_PMIC_CONTROL) > writel(readl(USB_PHY_CTRL) | PHY_RETEN, USB_PHY_CTRL); > > - clk_disable(motg->pclk); > - clk_disable(motg->clk); > + clk_disable_unprepare(motg->pclk); > + clk_disable_unprepare(motg->clk); > if (motg->core_clk) > - clk_disable(motg->core_clk); > + clk_disable_unprepare(motg->core_clk); > I was under assumption that system suspend/resume might be called from the interrupt context. If that is case then its not appropriate to call clk_prepare/unprepare here right? or my understanding is not correct???? -- Pankaj Jangra -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists