linux-kernel - Re: [PATCH 09/10] ARM: msm: Make proc_comm clock control into a platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 26 Sep 2012 23:33:30 +0530
From:	Pankaj Jangra <jangra.pankaj9@...il.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	David Brown <davidb@...eaurora.org>,
	Daniel Walker <dwalker@...o99.com>,
	Bryan Huntsman <bryanh@...eaurora.org>,
	linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Saravana Kannan <skannan@...eaurora.org>
Subject: Re: [PATCH 09/10] ARM: msm: Make proc_comm clock control into a
 platform driver

Hi Stephen,

Its good  you started moving the msm to common clock framework.:)
I hope msm's codeaurora tree will also be moved to CCF soon. :)

On Fri, Sep 21, 2012 at 7:56 AM, Stephen Boyd <sboyd@...eaurora.org> wrote:
> To move closer to the generic struct clock framework move the
> proc_comm based clock code to a platform driver. The data
> describing the struct clks still live in the devices-$ARCH file,
> but the clock initialization is done at driver binding time.
>
> Cc: Saravana Kannan <skannan@...eaurora.org>
> Signed-off-by: Stephen Boyd <sboyd@...eaurora.org>
> ---
Reviewed-by: Pankaj Jangra<jangra.pankaj9@...il.com>

>  arch/arm/mach-msm/board-halibut.c      |  2 +-
>  arch/arm/mach-msm/board-msm7x30.c      |  2 +-
>  arch/arm/mach-msm/board-qsd8x50.c      |  2 +-
>  arch/arm/mach-msm/board-trout.c        |  3 +--
>  arch/arm/mach-msm/clock-pcom.c         | 23 +++++++++++++++++++++--
>  arch/arm/mach-msm/clock-pcom.h         |  5 +++++
>  arch/arm/mach-msm/clock.c              |  2 +-
>  arch/arm/mach-msm/clock.h              |  3 +++
>  arch/arm/mach-msm/devices-msm7x00.c    | 12 ++++++++++--
>  arch/arm/mach-msm/devices-msm7x30.c    | 11 +++++++++--
>  arch/arm/mach-msm/devices-qsd8x50.c    | 11 +++++++++--
>  arch/arm/mach-msm/devices.h            | 15 +++------------
>  arch/arm/mach-msm/include/mach/board.h |  5 -----
>  13 files changed, 65 insertions(+), 31 deletions(-)
>
> diff --git a/arch/arm/mach-msm/board-halibut.c b/arch/arm/mach-msm/board-halibut.c
> index 6ce542e..3c8cfe4 100644
> --- a/arch/arm/mach-msm/board-halibut.c
> +++ b/arch/arm/mach-msm/board-halibut.c
> @@ -59,6 +59,7 @@ static struct platform_device smc91x_device = {
>  };

> +
> +static int __devinit msm_clock_pcom_probe(struct platform_device *pdev)
> +{
> +       struct pcom_clk_pdata *pdata = pdev->dev.platform_data;

Should'nt it be const struct?

> +       msm_clock_init(pdata->lookup, pdata->num_lookups);
> +       return 0;
> +}
> +
--
Pankaj Jangra
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/