linux-kernel - Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120927080940.GO12592@arwen.pp.htv.fi>
Date:	Thu, 27 Sep 2012 11:09:42 +0300
From:	Felipe Balbi <balbi@...com>
To:	Andy Shevchenko <andy.shevchenko@...il.com>
Cc:	balbi@...com, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Viresh Kumar <viresh.linux@...il.com>,
	Vinod Koul <vinod.koul@...el.com>,
	linux-kernel@...r.kernel.org,
	spear-devel <spear-devel@...t.st.com>,
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCHv3 5/7] dmaengine: dw_dmac: add PCI part of the driver

Hi,

On Thu, Sep 27, 2012 at 11:08:12AM +0300, Andy Shevchenko wrote:
> >> +     .is_private = 1,
> >> +     .chan_allocation_order = CHAN_ALLOCATION_ASCENDING,
> >> +     .chan_priority = CHAN_PRIORITY_ASCENDING,
> >> +};
> >
> > This is the same for all of the PCI IDs listed below, looks like it's
> > best to just add it as platform_data of the dwc_dmac device directly,
> > rather than passing a pointer to this via driver->data.
> It potentially could be altered. I prefer to leave it as structure in
> the pci driver.

fair enough ;-)

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)