linux-kernel - Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120927102011.GF10549@amd.com>
Date:	Thu, 27 Sep 2012 12:20:11 +0200
From:	Joerg Roedel <joerg.roedel@....com>
To:	Shuah Khan <shuah.khan@...com>
CC:	<konrad.wilk@...cle.com>, <tglx@...utronix.de>, <mingo@...hat.com>,
	<hpa@...or.com>, <rob@...dley.net>, <akpm@...ux-foundation.org>,
	<bhelgaas@...gle.com>, <stern@...land.harvard.edu>,
	LKML <linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>,
	<devel@...uxdriverproject.org>, <x86@...nel.org>,
	<shuahkhan@...il.com>
Subject: Re: [PATCH v2] dma-debug: New interfaces to debug dma mapping errors

Hi Shuah,

the patch looks better then the older versions. It comes closer to a
merge, but I see one issue here:

On Tue, Sep 25, 2012 at 07:05:17PM -0600, Shuah Khan wrote:
> debug_dma_mapping_error(struct device *dev, dma_addr_t dma_addr):
> 	Sets dma map error checked status for the dma map entry if one is
> 	found. Decrements the system wide dma_map_errors_not_checked counter
> 	that is incremented by debug_dma_map_page() when it checks for
> 	mapping error before adding it to the dma debug entry table.

It is problematic that the DMA debug code can no longer call
dma_mapping_error because of this. How about adding a special version of
that function which does no checking and use it in the DMA debug code
instead?


Regards,

	Joerg

-- 
AMD Operating System Research Center

Advanced Micro Devices GmbH Einsteinring 24 85609 Dornach
General Managers: Alberto Bozzo
Registration: Dornach, Landkr. Muenchen; Registerger. Muenchen, HRB Nr. 43632

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/