linux-kernel - Re: [PATCH 09/57] power: ab8500_fg: usleep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120927023648.GA8836@lizard>
Date:	Wed, 26 Sep 2012 19:36:48 -0700
From:	Anton Vorontsov <anton.vorontsov@...aro.org>
To:	mathieu.poirier@...aro.org
Cc:	linux-kernel@...r.kernel.org, dwmw2@...radead.org
Subject: Re: [PATCH 09/57] power: ab8500_fg: usleep_range instead of short
 msleep

On Tue, Sep 25, 2012 at 10:12:06AM -0600, mathieu.poirier@...aro.org wrote:
> From: Jonas Aaberg <jonas.aberg@...ricsson.com>
> 
> Signed-off-by: Jonas ABERG <jonas.aberg@...ricsson.com>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@...aro.org>
> Reviewed-by: Johan BJORNSTEDT <johan.bjornstedt@...ricsson.com>
> ---
>  drivers/power/ab8500_fg.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/power/ab8500_fg.c b/drivers/power/ab8500_fg.c
> index 1e02b00..0db17c7 100644
> --- a/drivers/power/ab8500_fg.c
> +++ b/drivers/power/ab8500_fg.c
> @@ -957,7 +957,7 @@ static int ab8500_fg_load_comp_volt_to_capacity(struct ab8500_fg *di)
>  	do {
>  		vbat += ab8500_fg_bat_voltage(di);
>  		i++;
> -		msleep(5);
> +		usleep_range(5000, 5001);

Um.. why? From the commit message it's not obvious the rationale behind
this change. :-)

>  	} while (!ab8500_fg_inst_curr_done(di));
>  
>  	ab8500_fg_inst_curr_finalize(di, &di->inst_curr);
> -- 
> 1.7.5.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/