linux-kernel - Re: [PATCH] mfd: da9052-core: Fix request_threaded

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120927140843.GX4428@opensource.wolfsonmicro.com>
Date:	Thu, 27 Sep 2012 15:08:44 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	sameo@...ux.intel.com, marex@...x.de,
	ashish.jangam@...tcummins.com, dchen@...semi.com,
	linux-kernel@...r.kernel.org,
	Fabio Estevam <fabio.estevam@...escale.com>
Subject: Re: [PATCH] mfd: da9052-core: Fix request_threaded_irq() parameter

On Thu, Sep 27, 2012 at 12:55:35AM -0300, Fabio Estevam wrote:
> From: Fabio Estevam <fabio.estevam@...escale.com>
> 
> On a mx53qsb dt-kernel the da9052-core driver fails to probe:
> 
> da9052 1-0048: DA9052 ADC IRQ failed ret=-22
> 
> In request_threaded_irq() the first parameter is missing the da9052->irq_base.
> 
> Fix it and avoid the error.

The driver shouldn't be relying on irq_base at all, it should use
regmap_get_virq() to look up the interrupt number.  If it relies on
irq_base then the user is forced to assign one (or rely on automatic
assignment, which is a bit erratic.  Otherwise it can use a linear
domain which doesn't rely on being able to allocate a big block of
interrupt numbers.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/