| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Sep 2012 14:42:07 +0000 From: Arnd Bergmann <arnd@...db.de> To: Vinod Koul <vinod.koul@...ux.intel.com> Cc: viresh kumar <viresh.kumar@...aro.org>, Andy Shevchenko <andy.shevchenko@...il.com>, Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, linux-kernel@...r.kernel.org, Heikki Krogerus <heikki.krogerus@...ux.intel.com>, "spear-devel" <spear-devel@...t.st.com> Subject: Re: [PATCHv2 2/4] dmaengine: dw_dmac: Add PCI part of the driver On Thursday 27 September 2012, Vinod Koul wrote: > > where the first one is called by the other two, depending on the bus type. > > This could be done either splitting the driver into multiple files so you can > > have the platform and pci parts in separate driver modules depending on the > > common module that does all the actual work, or everything can be put in > > a single file with an #ifdef CONFIG_PCI to disable the pci driver parts > > when they don't apply. > > probe wont be called if PCI device is not loaded, so see no reason why > CONFIG_xxx would be needed I assumed that you could not have a call to pci_register_driver with CONFIG_PCI disabled. It seems that the function is stubbed out, so you're probably right that we can do it even without the #ifdef. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists