| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 27 Sep 2012 21:11:19 +0530 From: Inderpal Singh <inderpal.singh@...aro.org> To: Vinod Koul <vinod.koul@...ux.intel.com> Cc: Jassi Brar <jassisinghbrar@...il.com>, linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org, boojin.kim@...sung.com, patches@...aro.org, kgene.kim@...sung.com Subject: Re: [PATCH 3/3] DMA: PL330: Balance module remove function with probe On 27 September 2012 15:18, Vinod Koul <vinod.koul@...ux.intel.com> wrote: > On Wed, 2012-09-26 at 12:11 +0530, Inderpal Singh wrote: >> If we fail pl330_remove while some client is queued, the force unload >> will fail and the >> force unload will lose its purpose. >> How about conditionally DMA_TERMINATE_ALL and free resources like >> below ? > Why would you want to remove the driver when it is doing something > useful? You have to ensure driver is not doing anything. > > What is point here? > As mentioned by jassi, if the pl330 module is forced unloaded while some client is queued, we have to manually do DMA_TERMINATE_ALL. If failing remove is a better option in case some client is queued, we can do away with DMA_TERMINATE_ALL and free_chan_resources and simply return a suitable error code from remove. Kindly suggest. Thanks, Inder > -- > ~Vinod > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists