linux-kernel - Re: kernel BUG at /data/lemmy/linux.trees.git/fs/nfs/idmap.c:681!

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4FA345DA4F4AE44899BD2B03EEEC2FA908FEF7A3@SACEXCMBX04-PRD.hq.netapp.com>
Date:	Thu, 27 Sep 2012 16:16:25 +0000
From:	"Myklebust, Trond" <Trond.Myklebust@...app.com>
To:	Joerg Roedel <joro@...tes.org>
CC:	Joerg Roedel <joerg.roedel@....com>,
	"linux-nfs@...r.kernel.org" <linux-nfs@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>
Subject: Re: kernel BUG at /data/lemmy/linux.trees.git/fs/nfs/idmap.c:681!

On Thu, 2012-09-27 at 17:39 +0200, Joerg Roedel wrote:
> On Thu, Sep 27, 2012 at 03:32:02PM +0000, Myklebust, Trond wrote:
> 
> > Does your checked out copy of 3.6-rc7 contain commit c50669 (NFS:
> > Clear key construction data if the idmap upcall fails)? The latter was
> > merged in3.6-rc3, and is reported to fix the problem for the other
> > testers.
> 
> Yes, it contains that commit. I was about to test plain v3.6-rc7 without
> my patches (not nfs related, of cource) on-top, but unfortunatly the
> disk with the root-fs died :-/
> I am about to set up the box again and test plain -rc7.

Please do.

I cannot see how that BUG_ON can be triggered in the current code, given
that the only place where idmap->idmap_key_cons is set to a non-NULL
value is covered by a mutex, and that it is always cleared before we
release said mutex.

-- 
Trond Myklebust
Linux NFS client maintainer

NetApp
Trond.Myklebust@...app.com
www.netapp.com