linux-kernel - Re: [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50648DE7.2060904@suse.cz>
Date:	Thu, 27 Sep 2012 19:33:27 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Cyrill Gorcunov <gorcunov@...nvz.org>
CC:	linux-kernel@...r.kernel.org, alan@...rguk.ukuu.org.uk,
	hpa@...or.com, gregkh@...uxfoundation.org, xemul@...allels.com
Subject: Re: [patch 1/2] tty: pty - Move TIOCPKT handling into pty.c

On 09/27/2012 06:59 PM, Cyrill Gorcunov wrote:
> --- tty.git.orig/drivers/tty/pty.c
> +++ tty.git/drivers/tty/pty.c
> @@ -174,6 +174,31 @@ static int pty_set_lock(struct tty_struc
>  	return 0;
>  }
>  
> +/* Set the packet mode on a pty */
> +static int pty_set_pktmode(struct tty_struct *tty, int __user *arg)
> +{
> +	unsigned long flags;
> +	int pktmode;
> +
> +	if (tty->driver->subtype != PTY_TYPE_MASTER)
> +		return -ENOTTY;

Hi!

This check is not needed as the ioctls are master-only.

-- 
js
suse labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/