linux-kernel - Re: [PATCH v2 -tip 0/5] x86, MSI, AHCI: Support multiple MSIs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120927040335.GA1957@gmail.com>
Date:	Thu, 27 Sep 2012 06:03:35 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Alexander Gordeev <agordeev@...hat.com>
Cc:	Jeff Garzik <jgarzik@...ox.com>, Ingo Molnar <mingo@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Bjorn Helgaas <bhelgaas@...gle.com>,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Yinghai Lu <yinghai@...nel.org>,
	Matthew Wilcox <willy@...ux.intel.com>, x86@...nel.org,
	linux-pci@...r.kernel.org, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 -tip 0/5] x86, MSI, AHCI: Support multiple MSIs


* Alexander Gordeev <agordeev@...hat.com> wrote:

> On Mon, Sep 03, 2012 at 11:16:55AM +0200, Alexander Gordeev wrote:
> >   5/5:	based on Jeff's comments:
> > 
> > 	- AHCI specific code moved from libata-core.c to libahci.c;
> > 
> > 	- the host-wide lock concern addressed - ahci_interrupt() handler
> > 	  split in two parts: ahci_hw_interrupt() hardware context handler
> > 	  and ahci_thread_fn() threaded handler;
> > 
> > 	- host->lock statistics attached;
> 
> Hi Jeff,
> 
> Would you please comment on the changes and numbers?

Yep, given the diffstat:

 Documentation/PCI/MSI-HOWTO.txt |   37 ++++++-
 arch/x86/kernel/apic/io_apic.c  |  170 +++++++++++++++++++++++++++++--
 drivers/ata/ahci.c              |   14 ++-
 drivers/ata/ahci.h              |    5 +
 drivers/ata/libahci.c           |  211 +++++++++++++++++++++++++++++++++++++-
 drivers/pci/msi.c               |   36 ++++++-
 include/linux/irq.h             |    6 +
 include/linux/msi.h             |    1 +
 include/linux/pci.h             |    7 ++
 kernel/irq/chip.c               |   30 ++++--
 kernel/irq/irqdesc.c            |   31 ++++++
 11 files changed, 509 insertions(+), 39 deletions(-)

We absolutely need a very happy and enthusiastic Acked-by from 
Jeff before we can pursue it :-)

Thaks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/