linux-kernel - Re: [ 056/127] Bluetooth: Fix not removing power

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348870383.6858.5.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 29 Sep 2012 00:13:03 +0200
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk,
	Vinicius Costa Gomes <vinicius.gomes@...nbossa.org>,
	Gustavo Padovan <gustavo.padovan@...labora.co.uk>
Subject: Re: [ 056/127] Bluetooth: Fix not removing power_off delayed work

On Fri, 2012-09-28 at 13:33 -0700, Greg Kroah-Hartman wrote:
> 3.0-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Vinicius Costa Gomes <vinicius.gomes@...nbossa.org>
> 
> commit 78c04c0bf52360dc2f7185e99c8e9aa05d73ae5a upstream.
> 
> For example, when a usb reset is received (I could reproduce it
> running something very similar to this[1] in a loop) it could be
> that the device is unregistered while the power_off delayed work
> is still scheduled to run.
[...]
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -588,6 +588,8 @@ static int hci_dev_do_close(struct hci_d
>  {
>  	BT_DBG("%s %p", hdev->name, hdev);
>  
> +	cancel_delayed_work(&hdev->power_off);
[...]

This is not right for 3.0 as the type of hdev->power_off is struct
work_struct, not struct delayed_work.

When I looked at this for 3.2 it appeared that this fix might not be
required at all.

Ben.

-- 
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
                      - Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)