linux-kernel - Re: [PATCH 03/14] perf hists: Separate overhead and baseline columns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zk4au1vy.fsf@sejong.aot.lge.com>
Date:	Fri, 28 Sep 2012 14:56:01 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	linux-kernel@...r.kernel.org,
	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...e.hu>, Paul Mackerras <paulus@...ba.org>,
	Corey Ashford <cjashfor@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [PATCH 03/14] perf hists: Separate overhead and baseline columns

On Thu, 27 Sep 2012 13:09:24 +0200, Jiri Olsa wrote:
> Currently the overhead and baseline columns are handled within
> single function and the distinction is made by 'baseline hists'
> pointer passed by 'struct perf_hpp::ptr'.
>
> Since hists pointer is now part of each hist_entry, it's possible
> to locate paired hists pointer directly from the passed struct
> hist_entry pointer.
>
> Also separating those 2 columns makes the code more obvious.

Yes, it was thinking about something like this.


>
> Cc: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
> Cc: Peter Zijlstra <a.p.zijlstra@...llo.nl>
> Cc: Ingo Molnar <mingo@...e.hu>
> Cc: Paul Mackerras <paulus@...ba.org>
> Cc: Corey Ashford <cjashfor@...ux.vnet.ibm.com>
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: Namhyung Kim <namhyung@...nel.org>
> Signed-off-by: Jiri Olsa <jolsa@...hat.com>
> ---
[snip]
> +static int hpp__color_baseline(struct perf_hpp *hpp, struct hist_entry *he)
> +{
> +	double percent = baseline_percent(he);
> +
> +	return percent_color_snprintf(hpp->buf, hpp->size, "  %5.2f%%", percent);

Is it possible to have a baseline value over 100%?  I changed 'overhead'
colum format from '2 spaces + %5.2f + %' to '1 space + %6.2f + %' for
the case.  Probably it'd better using it here too for consistency.


> +}
> +
> +static int hpp__entry_baseline(struct perf_hpp *hpp, struct hist_entry *he)
> +{
> +	double percent = baseline_percent(he);
> +	const char *fmt = symbol_conf.field_sep ? "%.2f" : "  %5.2f%%";

Ditto.

Thanks,
Namhyung

> +
> +	return scnprintf(hpp->buf, hpp->size, fmt, percent);
> +}
> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/