lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Fri, 28 Sep 2012 13:43:47 +0400 From: Glauber Costa <glommer@...allels.com> To: Mel Gorman <mgorman@...e.de> CC: <linux-kernel@...r.kernel.org>, <cgroups@...r.kernel.org>, <kamezawa.hiroyu@...fujitsu.com>, <devel@...nvz.org>, Tejun Heo <tj@...nel.org>, <linux-mm@...ck.org>, Suleiman Souhlal <suleiman@...gle.com>, Frederic Weisbecker <fweisbec@...il.com>, "David Rientjes" <rientjes@...gle.com>, Christoph Lameter <cl@...ux.com>, "Pekka Enberg" <penberg@...helsinki.fi>, Michal Hocko <mhocko@...e.cz>, "Johannes Weiner" <hannes@...xchg.org> Subject: Re: [PATCH v3 07/13] mm: Allocate kernel pages to the right memcg On 09/27/2012 05:50 PM, Mel Gorman wrote: >> +void __free_accounted_pages(struct page *page, unsigned int order) >> > +{ >> > + memcg_kmem_uncharge_page(page, order); >> > + __free_pages(page, order); >> > +} >> > + >> > +void free_accounted_pages(unsigned long addr, unsigned int order) >> > +{ >> > + if (addr != 0) { >> > + VM_BUG_ON(!virt_addr_valid((void *)addr)); > This is probably overkill. If it's invalid, the next line is likely to > blow up anyway. It's no biggie. > So this is here because it is in free_pages() as well. If it blows, at least we know precisely why (if debugging), and VM_BUG_ON() is only compiled in when CONFIG_DEBUG_VM. But I'm fine with either. Should it stay or should it go ? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists