linux-kernel - Re: BUG_ON/panic proliferation.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Sep 2012 11:08:29 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Ryan Mallon <rmallon@...il.com>
Cc:	Dave Jones <davej@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	"Myklebust, Trond" <Trond.Myklebust@...app.com>,
	Joerg Roedel <joro@...tes.org>,
	Joerg Roedel <joerg.roedel@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: BUG_ON/panic proliferation.

> Remove panic calls from drivers/tty/pty.c
>     
> There is no need to panic the system if the allocation/registration of
> the pty drivers fails. Instead return an error and fail the module load.
>     
> Signed-off-by: Ryan Mallon <rmallon@...il.com>

NAK

this is pointless complexity

This is early boot up code. If it fails we ran out of memory before even
the base drivers got running. It's already game over.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/