linux-kernel - Re: CMA broken in next-20120926

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Sep 2012 11:27:28 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Peter Ujfalusi <peter.ujfalusi@...com>
Cc:	Minchan Kim <minchan@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thierry Reding <thierry.reding@...onic-design.de>,
	Marek Szyprowski <m.szyprowski@...sung.com>,
	Michal Nazarewicz <mina86@...a86.com>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Kyungmin Park <kyungmin.park@...sung.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>
Subject: Re: CMA broken in next-20120926

On Fri, Sep 28, 2012 at 11:48:25AM +0300, Peter Ujfalusi wrote:
> Hi,
> 
> On 09/28/2012 11:37 AM, Mel Gorman wrote:
> >> I hope this patch fixes the bug. If this patch fixes the problem
> >> but has some problem about description or someone has better idea,
> >> feel free to modify and resend to akpm, Please.
> >>
> > 
> > A full revert is overkill. Can the following patch be tested as a
> > potential replacement please?
> > 
> > ---8<---
> > mm: compaction: Iron out isolate_freepages_block() and isolate_freepages_range() -fix1
> > 
> > CMA is reported to be broken in next-20120926. Minchan Kim pointed out
> > that this was due to nr_scanned != total_isolated in the case of CMA
> > because PageBuddy pages are one scan but many isolations in CMA. This
> > patch should address the problem.
> > 
> > This patch is a fix for
> > mm-compaction-acquire-the-zone-lock-as-late-as-possible-fix-2.patch
> > 
> > Signed-off-by: Mel Gorman <mgorman@...e.de>
> 
> linux-next + this patch alone also works for me.
> 
> Tested-by: Peter Ujfalusi <peter.ujfalusi@...com>

Thanks Peter. I expect it also works for Thierry as I expect you were
suffering the same problem but obviously confirmation of that would be nice.

Andrew, can you pick up this version of the patch instead of Minchan's
revert?

Thanks Minchan for pointing out the obvious flaw in "mm: compaction:
Iron out isolate_freepages_block() and isolate_freepages_range()".

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/