linux-kernel - re: mtip32xx:Added appropriate timeout value for secure erase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120928122531.GA9260@elgon.mountain>
Date:	Fri, 28 Sep 2012 15:25:31 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	smani@...ron.com
Cc:	Jens Axboe <axboe@...nel.dk>, linux-kernel@...r.kernel.org
Subject: re: mtip32xx:Added appropriate timeout value for secure erase

Hello Selvan Mani,

The patch 75e152877069: "mtip32xx:Added appropriate timeout value for 
secure erase" from Sep 27, 2012, leads to the following warning:
drivers/block/mtip32xx/mtip32xx.c:2222 exec_drive_taskfile()
	 error: potential NULL dereference 'outbuf'.

  2220          /* check for erase mode support during secure erase.*/
  2221          if ((fis.command == ATA_CMD_SEC_ERASE_UNIT)
  2222                                          && (outbuf[0] & MTIP_SEC_ERASE_MODE)) {
                                                    ^^^^^^
Smatch complains that if taskout is zero this is a NULL dereference.
Obviously that's not normal, but it looks like it might be possible.

  2223                  erasemode = 1;
  2224          }

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/