linux-kernel - Re: [PATCH] CMA: decrease cc.nr_migratepages after reclaiming pagelist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120928131043.GD29125@suse.de>
Date:	Fri, 28 Sep 2012 14:10:43 +0100
From:	Mel Gorman <mgorman@...e.de>
To:	Minchan Kim <minchan@...nel.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Michal Nazarewicz <mina86@...a86.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	Marek Szyprowski <m.szyprowski@...sung.com>
Subject: Re: [PATCH] CMA: decrease cc.nr_migratepages after reclaiming
 pagelist

On Wed, Sep 26, 2012 at 03:50:12PM +0900, Minchan Kim wrote:
> The reclaim_clean_pages_from_list reclaims clean pages before
> migration so cc.nr_migratepages should be updated.
> Currently, there is no problem but it can be wrong if we
> try to use the vaule in future.
> 
> Cc: Mel Gorman <mgorman@...e.de>
> Cc: Michal Nazarewicz <mina86@...a86.com>
> Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
> Cc: Marek Szyprowski <m.szyprowski@...sung.com>
> Signed-off-by: Minchan Kim <minchan@...nel.org>

Yeah ok. As you say, it shouldn't actually affect anything currently and
cc.migratepages is expected to go out of date after migration meaning we
need update_nr_listpages. This patch looks ok though.

Acked-by: Mel Gorman <mgorman@...e.de>

-- 
Mel Gorman
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/