| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120928142017.GE7483@localhost.localdomain>
Date: Fri, 28 Sep 2012 10:20:18 -0400
From: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To: Joerg Roedel <joerg.roedel@....com>
Cc: iommu@...ts.linux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/16] iommu/amd: Add IRTE invalidation routine
On Fri, Sep 28, 2012 at 02:23:57PM +0200, Joerg Roedel wrote:
> Add routine to invalidate the IOMMU cache for interupt
> translations. Also include the IRTE caches when flushing all
> IOMMU caches.
>
> Signed-off-by: Joerg Roedel <joerg.roedel@....com>
> ---
> drivers/iommu/amd_iommu.c | 27 +++++++++++++++++++++++++++
> drivers/iommu/amd_iommu_types.h | 1 +
> 2 files changed, 28 insertions(+)
>
> diff --git a/drivers/iommu/amd_iommu.c b/drivers/iommu/amd_iommu.c
> index b6a8079..a2c1f7a 100644
> --- a/drivers/iommu/amd_iommu.c
> +++ b/drivers/iommu/amd_iommu.c
> @@ -902,6 +902,13 @@ static void build_inv_all(struct iommu_cmd *cmd)
> CMD_SET_TYPE(cmd, CMD_INV_ALL);
> }
>
> +static void build_inv_irt(struct iommu_cmd *cmd, u16 devid)
> +{
> + memset(cmd, 0, sizeof(*cmd));
> + cmd->data[0] = devid;
> + CMD_SET_TYPE(cmd, CMD_INV_IRT);
> +}
> +
> /*
> * Writes the command to the IOMMUs command buffer and informs the
> * hardware about the new command.
> @@ -1023,12 +1030,32 @@ static void iommu_flush_all(struct amd_iommu *iommu)
> iommu_completion_wait(iommu);
> }
>
> +static void iommu_flush_irt(struct amd_iommu *iommu, u16 devid)
> +{
> + struct iommu_cmd cmd;
> +
> + build_inv_irt(&cmd, devid);
> +
> + iommu_queue_command(iommu, &cmd);
> +}
> +
> +static void iommu_flush_irt_all(struct amd_iommu *iommu)
> +{
> + u32 devid;
> +
> + for (devid = 0; devid <= 0xffff; ++devid)
Should this be #define? Or perhaps based of sizeof?
Is there a specific reason that it is u16 in the build_inv_irt but here it is u32?
> + iommu_flush_irt(iommu, devid);
> +
> + iommu_completion_wait(iommu);
> +}
> +
> void iommu_flush_all_caches(struct amd_iommu *iommu)
> {
> if (iommu_feature(iommu, FEATURE_IA)) {
> iommu_flush_all(iommu);
> } else {
> iommu_flush_dte_all(iommu);
> + iommu_flush_irt_all(iommu);
> iommu_flush_tlb_all(iommu);
> }
> }
> diff --git a/drivers/iommu/amd_iommu_types.h b/drivers/iommu/amd_iommu_types.h
> index 1a7d480..b183306 100644
> --- a/drivers/iommu/amd_iommu_types.h
> +++ b/drivers/iommu/amd_iommu_types.h
> @@ -152,6 +152,7 @@
> #define CMD_INV_DEV_ENTRY 0x02
> #define CMD_INV_IOMMU_PAGES 0x03
> #define CMD_INV_IOTLB_PAGES 0x04
> +#define CMD_INV_IRT 0x05
> #define CMD_COMPLETE_PPR 0x07
> #define CMD_INV_ALL 0x08
>
> --
> 1.7.9.5
>
>
> _______________________________________________
> iommu mailing list
> iommu@...ts.linux-foundation.org
> https://lists.linuxfoundation.org/mailman/listinfo/iommu
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists