linux-kernel - Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120928142924.GA22101@opensource.wolfsonmicro.com>
Date:	Fri, 28 Sep 2012 15:29:24 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Fabio Estevam <fabio.estevam@...escale.com>
Cc:	Fabio Estevam <festevam@...il.com>, sameo@...ux.intel.com,
	Marek Vasut <marex@...x.de>, ashish.jangam@...tcummins.com,
	dchen@...semi.com, arnd@...db.de, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: da9052-core:  Use regmap_irq_get_virq() and fix
 the probe

On Fri, Sep 28, 2012 at 11:33:24AM -0300, Fabio Estevam wrote:

> Would you prefer the version below? If so, I can send it as v3:

> -	da9052->irq_base = regmap_irq_chip_get_base(da9052->irq_data);
> +	da9052->irq = regmap_irq_get_virq(da9052->irq_data, 0);

No, this doesn't support linear domains, if you're going to do this it'd
be better to just leave it as irq_base though as discussed that's not
ideal.  When I've done these conversions I've just done the virq
conversion at every use.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/