linux-kernel - Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120928155121.GA22510@opensource.wolfsonmicro.com>
Date:	Fri, 28 Sep 2012 16:51:22 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Fabio Estevam <festevam@...il.com>
Cc:	Fabio Estevam <fabio.estevam@...escale.com>, sameo@...ux.intel.com,
	Marek Vasut <marex@...x.de>, ashish.jangam@...tcummins.com,
	dchen@...semi.com, arnd@...db.de, kernel@...gutronix.de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] mfd: da9052-core: Use regmap_irq_get_virq() and fix
 the probe

On Fri, Sep 28, 2012 at 12:37:35PM -0300, Fabio Estevam wrote:
> On Fri, Sep 28, 2012 at 11:29 AM, Mark Brown

> > No, this doesn't support linear domains, if you're going to do this it'd
> > be better to just leave it as irq_base though as discussed that's not
> > ideal.  When I've done these conversions I've just done the virq
> > conversion at every use.

> Ok, so if I understand you correctly you suggest that Samuel applies
> the v1 of the patch:
> https://lkml.org/lkml/2012/9/26/551

> Please confirm.

Well, I'd really rather fix it to work with linear domains while we're
at it.  Right now it's mostly working by accident rather than design
(and even for legacy domains it's doing the wrong thing since it doesn't
pass the irq_base into mfd_add_devices).  This is especially true if
we're looking at making the device DT only in which case there's really
no reason to use anything other than a linear domain.

But yes, of the changes posted thus far this is the best one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/