linux-kernel - Re: [PATCH] firewire: remove global lock around address handlers, convert to RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348851825.2229.1.camel@thor>
Date:	Fri, 28 Sep 2012 13:03:45 -0400
From:	Peter Hurley <peter@...leysoftware.com>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	"linux1394-devel@...ts.sourceforge.net" 
	<linux1394-devel@...ts.sourceforge.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] firewire: remove global lock around address handlers,
 convert to RCU

On Fri, 2012-09-28 at 05:38 -0400, Stefan Richter wrote:
> On Sep 27 Stefan Richter wrote:
> > --- a/drivers/firewire/core-transaction.c
> > +++ b/drivers/firewire/core-transaction.c
> > @@ -489,7 +489,7 @@ static struct fw_address_handler *lookup
> >  {
> >  	struct fw_address_handler *handler;
> >  
> > -	list_for_each_entry(handler, list, link) {
> > +	list_for_each_entry_rcu(handler, list, link) {
> >  		if (handler->offset < offset + length &&
> >  		    offset < handler->offset + handler->length)
> >  			return handler;
> [...]
> 
> I will add an #include <linux/rculist.h> to core-transaction.c.

Thanks Stefan. Apologies for missing that.

Peter Hurley
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/