linux-kernel - Re: [ 080/262] usb: gadget: dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1348945275.18878.32.camel@deadeye.wl.decadent.org.uk>
Date:	Sat, 29 Sep 2012 21:01:15 +0200
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Sebastian Andrzej Siewior <sebastian@...akpoint.cc>,
	Felipe Balbi <balbi@...com>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	alan@...rguk.ukuu.org.uk,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [ 080/262] usb: gadget: dummy_hcd: fixup error probe path

On Fri, 2012-09-28 at 11:50 -0700, Greg Kroah-Hartman wrote:
> From: Greg KH <gregkh@...uxfoundation.org>
> 
> 3.5-stable review patch.  If anyone has any objections, please let me know.
> 
> ------------------
> 
> From: Sebastian Andrzej Siewior <sebastian@...akpoint.cc>
> 
> commit 1b68a4ca2d038addb7314211d122fb6d7002b38b upstream.
> 
> If USB2 host controller probes fine but USB3 does not then we don't
> remove the USB controller properly and lock up the system while the HUB
> code will try to enumerate the USB2 controller and access memory which
> is no longer available in case the dummy_hcd was compiled as a module.
> 
> This is a problem since 448b6eb1 ("USB: Make sure to fetch the BOS desc
> for roothubs.) if used in USB3 mode because dummy does not provide this
> descriptor and explodes later.
[...]

i.e. for 3.5 (as noted in the cc: stable line).  But I don't see why
this isn't needed for earlier kernel versions.  The same broken error
handling is present.

Ben.

-- 
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
                      - Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)