linux-kernel - Re: [PATCH 2/4] arch/um/os-Linux: Drop UM_ prefix from printk() level specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWiDKV2=kbO8UGqZBETdrYExLRbaRFNnVTVRcWUs16OcA@mail.gmail.com>
Date:	Sat, 29 Sep 2012 22:27:44 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Joe Perches <joe@...ches.com>
Cc:	Richard Weinberger <richard@....at>,
	user-mode-linux-devel@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 2/4] arch/um/os-Linux: Drop UM_ prefix from printk() level specifiers

On Sat, Sep 29, 2012 at 10:10 PM, Joe Perches <joe@...ches.com> wrote:
>> @@ -88,7 +88,7 @@ static int do_aio(aio_context_t ctx, enum aio_type type, int fd, char *buf,
>>               iocbp->aio_nbytes = sizeof(c);
>>               break;
>>       default:
>> -             printk(UM_KERN_ERR "Bogus op in do_aio - %d\n", type);
>> +             printk(KERN_ERR "Bogus op in do_aio - %d\n", type);
>
> Maybe a follow-on patch to convert these to pr_<level>?

That requires adding pr_<level> to arch/um/include/shared/user.h first.
Or to avoid duplication, extracting the pr_<level> definitions from
include/linux/printk.h to a new header file, and preincluding that one for
the user part of UML, too.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/