linux-kernel - Re: Probable false positive in checkpatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 28 Sep 2012 21:53:11 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Joe Perches <joe@...ches.com>
cc:	Andy Whitcroft <apw@...onical.com>,
	Kernel development list <linux-kernel@...r.kernel.org>
Subject: Re: Probable false positive in checkpatch

On Fri, 28 Sep 2012, Joe Perches wrote:

> On Fri, 2012-09-28 at 15:50 -0400, Alan Stern wrote:
> > Here's what I just got from checkpatch:
> > 
> > ERROR: space prohibited after that '-' (ctx:BxW)
> > #22: FILE: drivers/usb/host/ehci-sched.c:1419:
> > +                       start += (next - start + period - 1) & (- period);
> >                                                                 ^
> > This seems unlikely to be a real style violation.  Or if it is, maybe 
> > it shouldn't be.  After all, "(0 - period)" would be okay.
> 
> 2c: I think the recommendation is proper and correct.

I just looked in CodingStyle, and sure enough, there it is in section 
3.1.  The complaint is hereby withdrawn.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/