lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5068D185.9000802@att.net> Date: Sun, 30 Sep 2012 18:11:01 -0500 From: Daniel Santos <danielfsantos@....net> To: LKML <linux-kernel@...r.kernel.org> CC: Andi Kleen <ak@...ux.intel.com>, Andrea Arcangeli <aarcange@...hat.com>, Andrew Morton <akpm@...ux-foundation.org>, Christopher Li <sparse@...isli.org>, David Daney <david.daney@...ium.com>, David Howells <dhowells@...hat.com>, Joe Perches <joe@...ches.com>, Konstantin Khlebnikov <khlebnikov@...nvz.org>, linux-sparse@...r.kernel.org, Michel Lespinasse <walken@...gle.com>, Paul Gortmaker <paul.gortmaker@...driver.com>, Pavel Pisa <pisa@....felk.cvut.cz>, Peter Zijlstra <a.p.zijlstra@...llo.nl>, Steven Rostedt <rostedt@...dmis.org>, Borislav Petkov <bp@...en8.de>, Josh Triplett <josh@...htriplett.org> Subject: Re: [PATCH 3/10] compiler-gcc.h: Add gcc-recommended GCC_VERSION macro So in light of feedback I've been getting on this patch set, it leaves me with this question. > +#define GCC_VERSION (__GNUC__ * 10000 \ > + + __GNUC_MINOR__ * 100 \ > + + __GNUC_PATCHLEVEL__) This macro presumes you are using gcc 3.0 or later, which introduced the __GNUC_PATCHLEVEL__ predefined macro. Should you be using a version of gcc prior to 3.0 (where the macro is undefined), you would get an error that __GNUC_PATCHLEVEL__ is undefined prior to getting the error trying to include "linux/compiler-gcc2.h". So it presumes the compiler is 3.0+, when another part of the code may allow it from a future change. Should it be modified to do account for this or would that be overkill? #ifdef __GNUC_PATCHLEVEL__ # define GCC_VERSION (__GNUC__ * 10000 \ + __GNUC_MINOR__ * 100 \ + __GNUC_PATCHLEVEL__) #else # define GCC_VERSION (__GNUC__ * 10000 \ + __GNUC_MINOR__ * 100) #endif Daniel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists