lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 1 Oct 2012 11:22:28 +0100 From: Lee Jones <lee.jones@...aro.org> To: "Rajanikanth H.V" <rajanikanth.hv@...ricsson.com> Cc: francescolavra.fl@...il.com, arnd@...db.de, anton.vorontsov@...aro.org, linus.walleij@...ricsson.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, linaro-dev@...ts.linaro.org, patches@...aro.org, STEricsson_nomadik_linux@...t.st.com Subject: Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge Sorry, some mistakes: > > From: "Rajanikanth H.V" <rajanikanth.hv@...ricsson.com> > > > > - This patch adds device tree support for fuelguage driver > > - optimize bm devices platform_data usage and of_probe(...) > > Note: of_probe() routine for battery managed devices is made > > common across all bm drivers. Spelling errors in here. > > + dev_err(dev, "invalid battery-info node\n"); > > + return -EINVAL; > > + } > > + if (of_property_read_bool(np_bat_supply, > > + "thermistor-on-batctrl") == false){ > > Replace with: > if (of_get_property(np_bat_supply, "thermistor-on-batctr", NULL)) > np_bat_supply = true; This should be: if (of_get_property(np_bat_supply, "thermistor-on-batctr", NULL)) thermistor = NTC_INTERNAL; else thermistor = NTC_EXTERNAL; > <remove> > > > + dev_warn(dev, "missing property thermistor-on-batctrl\n"); > > + thermistor = NTC_EXTERNAL; > > + } > > </remove> -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists