linux-kernel - Re: [PATCH 2/2] tg3: fix build-time dependency with IS_DEPENDENCY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20121001.174535.32880983714519058.davem@davemloft.net>
Date:	Mon, 01 Oct 2012 17:45:35 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	paul.gortmaker@...driver.com
Cc:	anisse@...ier.eu, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, mmarek@...e.cz,
	torvalds@...ux-foundation.org, mchan@...adcom.com,
	mcarlson@...adcom.com
Subject: Re: [PATCH 2/2] tg3: fix build-time dependency with
 IS_DEPENDENCY_SATISFIED()

From: Paul Gortmaker <paul.gortmaker@...driver.com>
Date: Mon, 1 Oct 2012 12:10:59 -0400

> From e7c432cf5eb44b188c1aa2b188877c42300de8b9 Mon Sep 17 00:00:00 2001
> From: Paul Gortmaker <paul.gortmaker@...driver.com>
> Date: Mon, 1 Oct 2012 11:43:49 -0400
> Subject: [PATCH] tg3: unconditionally select HWMON support when tg3 is
>  enabled.
> 
> There is the seldom used corner case where HWMON=m at the same
> time as TIGON3=y (typically randconfigs) which will cause a link
> fail like:
> 
> drivers/built-in.o: In function `tg3_close':
> tg3.c:(.text+0x16bd86): undefined reference to `hwmon_device_unregister'
> drivers/built-in.o: In function `tg3_hwmon_open':
> tg3.c:(.text+0x16fc4b): undefined reference to `hwmon_device_register'
> make[1]: *** [vmlinux] Error 1
> 
> Fix it as suggested by DaveM[1] by having the Kconfig logic simply
> select HWMON when TIGON3 is selected.  This gets rid of all the
> extra IS_ENABLED ifdeffery in tg3.c as a side benefit.
> 
> [1] http://marc.info/?l=linux-netdev&m=134250573718151&w=2
> 
> Cc: Michael Chan <mchan@...adcom.com>
> Reported-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Reported-by: Anisse Astier <anisse@...ier.eu>
> Suggested-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/