linux-kernel - Re: [PATCH v2] kbuild: Fix gcc -x syntax

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121001072739.GC17166@gmail.com>
Date:	Mon, 1 Oct 2012 09:27:39 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Jean Delvare <jdelvare@...e.de>
Cc:	linux-kernel@...r.kernel.org, x86@...nel.org,
	Bernhard Walle <bernhard@...lle.de>,
	Michal Marek <mmarek@...e.cz>,
	Ralf Baechle <ralf@...ux-mips.org>
Subject: Re: [PATCH v2] kbuild: Fix gcc -x syntax


* Jean Delvare <jdelvare@...e.de> wrote:

> The correct syntax for gcc -x is "gcc -x assembler", not
> "gcc -xassembler". Even though the latter happens to work, the former
> is what is documented in the manual page and thus what gcc wrappers
> such as icecream do expect.
> 
> This isn't a cosmetic change. The missing space prevents icecream from
> recognizing compilation tasks it can't handle, leading to silent kernel
> miscompilations.
> 
> Besides me, credits go to Richard Guenther and Dirk Mueller for
> investigating the miscompilation issue and tracking it down to this
> incorrect -x parameter syntax.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: stable@...r.kernel.org
> Cc: Bernhard Walle <bernhard@...lle.de>
> Cc: Michal Marek <mmarek@...e.cz>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> ---
> Changes since v1:
>  * Found more occurrences of the same. These are probably less
>    problematic in practice but let's fix them all still.
> 
>  arch/mips/Makefile                         |    2 +-
>  arch/mips/kernel/Makefile                  |    2 +-
>  arch/x86/Makefile                          |    2 +-
>  scripts/Kbuild.include                     |   12 ++++++------
>  scripts/gcc-version.sh                     |    6 +++---
>  scripts/gcc-x86_32-has-stack-protector.sh  |    2 +-
>  scripts/gcc-x86_64-has-stack-protector.sh  |    2 +-
>  scripts/kconfig/check.sh                   |    2 +-
>  scripts/kconfig/lxdialog/check-lxdialog.sh |    2 +-
>  tools/perf/Makefile                        |    2 +-
>  tools/power/cpupower/Makefile              |    2 +-
>  11 files changed, 18 insertions(+), 18 deletions(-)

Acked-by: Ingo Molnar <mingo@...nel.org>

Michal, want to pick this one up into the kbuild tree?

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/