linux-kernel - Re: HID: picoLCD: optimize for inactive debugfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1210011025490.27440@pobox.suse.cz>
Date:	Mon, 1 Oct 2012 10:25:53 +0200 (CEST)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Bruno Prémont <bonbons@...ux-vserver.org>
Cc:	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: HID: picoLCD: optimize for inactive debugfs

On Sun, 30 Sep 2012, Bruno Prémont wrote:

> Matthieu CASTET adjusted picolcd_debug_out_report() to only operate when
> there is an active listener on debugfs for events.
> 
> His change got lost while splitting hid_picolcd.c, restore it.
> 
> Signed-off-by: Bruno Prémont <bonbons@...ux-vserver.org>
> ---
> 
> 
> diff --git a/drivers/hid/hid-picolcd_debugfs.c b/drivers/hid/hid-picolcd_debugfs.c
> index 6ef03be..4809aa1 100644
> --- a/drivers/hid/hid-picolcd_debugfs.c
> +++ b/drivers/hid/hid-picolcd_debugfs.c
> @@ -402,7 +402,7 @@ void picolcd_debug_out_report(struct picolcd_data *data,
>  #define BUFF_SZ 256
>  
>  	/* Avoid unnecessary overhead if debugfs is disabled */
> -	if (!hdev->debug_events)
> +	if (list_empty(&hdev->debug_list))
>  		return;
>  
>  	buff = kmalloc(BUFF_SZ, GFP_ATOMIC);

Applied, thanks.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/