linux-kernel - Re: [PATCH 1/3] perf tools: Check existence of _get_comp_words_by

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121002155358.GD10605@somewhere>
Date:	Tue, 2 Oct 2012 17:54:10 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Namhyung Kim <namhyung@...nel.org>
Cc:	Arnaldo Carvalho de Melo <acme@...stprotocols.net>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	David Ahern <dsahern@...il.com>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/3] perf tools: Check existence of
 _get_comp_words_by_ref when bash completing

On Wed, Oct 03, 2012 at 12:21:32AM +0900, Namhyung Kim wrote:
> The '_get_comp_words_by_ref' function is available from the bash
> completion v1.2 so that earlier version emits following warning:
> 
>   $ perf re<TAB>_get_comp_words_by_ref: command not found
> 
> Use older '_get_cword' method when the above function doesn't exist.

May be only use _get_cword then, if it works everywhere?

> 
> Cc: Frederic Weisbecker <fweisbec@...il.com>
> Cc: David Ahern <dsahern@...il.com>
> Signed-off-by: Namhyung Kim <namhyung@...nel.org>
> ---
>  tools/perf/bash_completion |   15 +++++++++++++--
>  1 file changed, 13 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/perf/bash_completion b/tools/perf/bash_completion
> index 1958fa539d0f..3d48cee1b5e5 100644
> --- a/tools/perf/bash_completion
> +++ b/tools/perf/bash_completion
> @@ -1,12 +1,23 @@
>  # perf completion
>  
> +function_exists()
> +{
> +	declare -F $1 > /dev/null
> +	return $?
> +}
> +
>  have perf &&
>  _perf()
>  {
> -	local cur cmd
> +	local cur prev cmd
>  
>  	COMPREPLY=()
> -	_get_comp_words_by_ref cur prev
> +	if function_exists _get_comp_words_by_ref; then
> +		_get_comp_words_by_ref cur prev
> +	else
> +		cur=$(_get_cword)
> +		prev=${COMP_WORDS[COMP_CWORD-1]}
> +	fi
>  
>  	cmd=${COMP_WORDS[0]}
>  
> -- 
> 1.7.9.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/