lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 2 Oct 2012 11:12:50 -0700 From: Greg KH <gregkh@...uxfoundation.org> To: Andy Shevchenko <andy.shevchenko@...il.com> Cc: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>, YAMANE Toshiaki <yamanetoshi@...il.com> Subject: Re: [PATCH 1/7] string: introduce helper to get base file name from given path On Tue, Oct 02, 2012 at 08:52:05PM +0300, Andy Shevchenko wrote: > On Tue, Oct 2, 2012 at 8:34 PM, Greg KH <gregkh@...uxfoundation.org> wrote: > > On Tue, Oct 02, 2012 at 06:00:54PM +0300, Andy Shevchenko wrote: > >> There are several places in kernel that use functionality like shell's basename > >> function. Let's do it common helper for them. > >> > >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> > >> Cc: YAMANE Toshiaki <yamanetoshi@...il.com> > >> --- > >> include/linux/string.h | 11 +++++++++++ > >> 1 file changed, 11 insertions(+) > >> > >> diff --git a/include/linux/string.h b/include/linux/string.h > >> index b917881..b09a342 100644 > >> --- a/include/linux/string.h > >> +++ b/include/linux/string.h > >> @@ -147,5 +147,16 @@ static inline bool strstarts(const char *str, const char *prefix) > >> > >> extern size_t memweight(const void *ptr, size_t bytes); > >> > >> +/** > >> + * kbasename - return the last part of a pathname. > >> + * > >> + * @path: path to extract the filename from. > >> + */ > >> +static inline const char *kbasename(const char *path) > >> +{ > >> + const char *tail = strrchr(path, '/'); > >> + return tail ? tail + 1 : path; > > > > What happens if '/' is the last thing in the string? You will then > > point to an empty string, which I don't think all callers of this > > function is assuming going to work properly (hint, the USB caller will > > not...) > Thanks for pointing to that. I think it's a usb specific case, so, I > assume your comment related to that patch. Well, if you want your kbasename() function to work like the basename(3) function, you need to properly handle a trailing '/' character. And yes, the USB code does check for this. I don't remember why, odds are it was needed for something. greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists