linux-kernel - Re: [PATCH 07/17] ARM: at91: skip at91_io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121002185651.GC5117@game.jcrosoft.org>
Date:	Tue, 2 Oct 2012 20:56:51 +0200
From:	Jean-Christophe PLAGNIOL-VILLARD <plagnioj@...osoft.com>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...radead.org, arm@...nel.org,
	linux-kernel@...r.kernel.org,
	Nicolas Ferre <nicolas.ferre@...el.com>
Subject: Re: [PATCH 07/17] ARM: at91: skip at91_io_desc definition for NOMMU

On 18:36 Tue 02 Oct     , Arnd Bergmann wrote:
> On NOMMU systems, we do cannot remap the MMIO space, so the
> definition of at91_io_desc is unused.
> 
> Without this patch, building at91x40_defconfig results in:
> 
> arch/arm/mach-at91/setup.c:90:24: warning: 'at91_io_desc' defined but not used [-Wunused-variable]
I prefer a __maybe_unused on the struct so the compilator will just drop it

Best Regards,
J.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: Nicolas Ferre <nicolas.ferre@...el.com>
> Cc: Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
> ---
>  arch/arm/mach-at91/setup.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c
> index 944bffb..b9fdba0 100644
> --- a/arch/arm/mach-at91/setup.c
> +++ b/arch/arm/mach-at91/setup.c
> @@ -87,12 +87,14 @@ void __init at91_init_sram(int bank, unsigned long base, unsigned int length)
>  	iotable_init(desc, 1);
>  }
>  
> +#ifdef CONFIG_MMU
>  static struct map_desc at91_io_desc __initdata = {
>  	.virtual	= AT91_VA_BASE_SYS,
>  	.pfn		= __phys_to_pfn(AT91_BASE_SYS),
>  	.length		= SZ_16K,
>  	.type		= MT_DEVICE,
>  };
> +#endif
>  
>  static void __init soc_detect(u32 dbgu_base)
>  {
> -- 
> 1.7.10
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/