linux-kernel - Re: [PATCH v3 0/2] ARM: davinci: da850/omap-l138: add support for VPIF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Oct 2012 13:47:58 +0530
From:	Sekhar Nori <nsekhar@...com>
To:	Prabhakar Lad <prabhakar.lad@...com>
CC:	LAK <linux-arm-kernel@...ts.infradead.org>,
	dlos <davinci-linux-open-source@...ux.davincidsp.com>,
	<linux-kernel@...r.kernel.org>,
	Manjunath Hadli <manjunath.hadli@...com>
Subject: Re: [PATCH v3 0/2] ARM: davinci: da850/omap-l138: add support for
 VPIF driver

Hi Prabhakar,

On 9/11/2012 11:55 AM, Prabhakar Lad wrote:
> This patch series adds support for VPIF
> capture and display driver on da850/omap-l138.
> Enables SD capture and display.
> 
> This patch series is dependent on the following patch:
> https://patchwork.kernel.org/patch/1332311/
> 
> Changes for v3:
> 1: Clubbed the code for DA850_UI_SD_VIDEO_PORT config
>    as pointed by Sekhar.
> 2: Define  the resource structure outside the function as pointed
>    by Sekhar.
> 
> Changes for v2:
> 1: Avoid breaking of print messages.
> 2: Removed the handlers which just returned zero (which did nothing).
> 3: Clubbed the code where ever possible for DA850_UI_SD_VIDEO_PORT
>    config option.
> 4: Removed the dma_declare_coherent_memory() calls and used
>    global CMA.
> 5: Added the base address in increasing order.
> 
> Manjunath Hadli (2):
>   ARM: da850/omap-l138: Add SoC related definitions for VPIF
>   ARM: da850/omap-l138: Add EVM specific code for VPIF to work
> 
> Manjunath Hadli (2):
>   ARM: da850/omap-l138: Add SoC related definitions for VPIF
>   ARM: da850/omap-l138: Add EVM specific code for VPIF to work
> 
>  arch/arm/mach-davinci/Kconfig              |    7 ++
>  arch/arm/mach-davinci/board-da850-evm.c    |  156 ++++++++++++++++++++++++++++
>  arch/arm/mach-davinci/da850.c              |  152 +++++++++++++++++++++++++++
>  arch/arm/mach-davinci/include/mach/da8xx.h |   11 ++
>  arch/arm/mach-davinci/include/mach/mux.h   |   42 ++++++++
>  arch/arm/mach-davinci/include/mach/psc.h   |    1 +
>  6 files changed, 369 insertions(+), 0 deletions(-)

The patches look good to me. In case you want to queue them through the
media tree to manage the dependencies, feel free to add my:

Acked-by: Sekhar Nori <nsekhar@...com>

Note that the subject like prefix for DA850 soc patches should be

"ARM: davinci: da850: .."

and that for DA850 EVM patches should be:

"ARM: davinci: da850 evm: .."

instead of what you have used here. Please fix these if you are queuing
them and take care of this in future.

Thanks,
Sekhar
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/