linux-kernel - Re: [PATCH 04/17] ARM: pxa: define palmte2_pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 3 Oct 2012 13:23:23 +0200
From:	Marek Vasut <marex@...x.de>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...radead.org, arm@...nel.org,
	linux-kernel@...r.kernel.org,
	Carlos Eduardo Medaglia Dyonisio <cadu@...dfeliz.com>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	Eric Miao <eric.y.miao@...il.com>
Subject: Re: [PATCH 04/17] ARM: pxa: define palmte2_pxa_keys conditionally

Dear Arnd Bergmann,

> Gcc prints a harmless warning about palmte2_pxa_keys not being used
> when the gpio keyboard driver is disabled. The solution is to use
> the same #ifdef that is already present in the place where the
> symbol is used.
> 
> Without this patch, building palmz72_defconfig results in:
> 
> /home/arnd/linux-arm/arch/arm/mach-pxa/palmte2.c:128:31: warning:
> 'palmte2_pxa_keys' defined but not used [-Wunused-variable]
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: Marek Vasut <marek.vasut@...il.com>
> Cc: Carlos Eduardo Medaglia Dyonisio <cadu@...dfeliz.com>
> Cc: Haojian Zhuang <haojian.zhuang@...il.com>
> Cc: Eric Miao <eric.y.miao@...il.com>

Acked-by: Marek Vasut <marex@...x.de>

Thanks Arnd

Best regards,
Marek Vasut
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/