linux-kernel - Re: [ 026/180] eCryptfs: Improve statfs reporting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349277229.16173.24.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 03 Oct 2012 16:13:49 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Tim Gardner <tim.gardner@...onical.com>
Cc:	Tyler Hicks <tyhicks@...onical.com>, Willy Tarreau <w@....eu>,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Colin Ian King <colin.king@...onical.com>,
	Stefan Bader <stefan.bader@...onical.com>
Subject: Re: [ 026/180] eCryptfs: Improve statfs reporting

On Tue, 2012-10-02 at 06:24 -0600, Tim Gardner wrote:
> On 10/01/2012 11:46 PM, Tyler Hicks wrote:
> > On 2012-10-02 00:52:23, Willy Tarreau wrote:
> >> 2.6.32-longterm review patch.  If anyone has any objections,
> >> please let me know.
> > 
> > Hi - Please drop this patch. It incorrectly calculates f_namelen
> > and I haven't had a chance to fix it yet. When I get a fix ready,
> > I'll forward the corrected patch to stable@....o. Thanks!
> > 
> > Tyler
> > 
> >> 
> >> ------------------
> >> 
> >> From: Tyler Hicks <tyhicks@...onical.com>
> >> 
> >> commit 4a26620df451ad46151ad21d711ed43e963c004e upstream.
[...]
> Tyler - this is the same patch that we're carrying in every kernel
> from Lucid to Quantal, right ? Colin has verified test cases for this,
> so I'm curious what you think is wrong. Something unique to 2.6.32 ?
> 
> https://bugs.launchpad.net/ecryptfs/+bug/885744/comments/5
> https://bugs.launchpad.net/ecryptfs/+bug/885744/comments/9

As I said in <1344208574.13142.59.camel@...deye.wl.decadent.org.uk>,
pathconf(_PC_NAME_MAX) needs to report an upper bound on the maximum
name length, not a lower bound, so that readdir_r() can be used safely.

Ben.

-- 
Ben Hutchings
For every complex problem
there is a solution that is simple, neat, and wrong.

Download attachment "signature.asc" of type "application/pgp-signature" (829 bytes)