linux-kernel - Re: [PATCH v3] Enable USB peripheral on dm365 EVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121003232311.GA14392@kroah.com>
Date:	Wed, 3 Oct 2012 16:23:11 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	const@...eLinux.com
Cc:	nsekhar@...com, davinci-linux-open-source@...ux.davincidsp.com,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, khilman@...com, balbi@...com,
	miguel.aguilar@...gerun.com, kernel-mentors@...enic.com
Subject: Re: [PATCH v3] Enable USB peripheral on dm365 EVM

On Thu, Oct 04, 2012 at 12:04:19AM +0200, const@...eLinux.com wrote:
> From: Constantine Shulyupin <const@...eLinux.com>
> 
> From: Miguel Aguilar <miguel.aguilar@...gerun.com>
> Signed-off-by: Constantine Shulyupin <const@...eLinux.com>
> ---
> Tested with usb gadget g_zero.
> This patch is based on code from Arago, Angstom, and RidgeRun projects.
> Original patch is three years ago:
> http://www.mail-archive.com/davinci-linux-open-source@linux.davincidsp.com/msg14741.html

You can't have two "From:" lines.

And put the information above, in the changelog entry.

Also, it looks like you are modifying printk lines for no reason, why do
that in this patch?  That shouldn't be needed, right?

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/