[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20121003233730.GB21410@roeck-us.net>
Date: Wed, 3 Oct 2012 16:37:30 -0700
From: Guenter Roeck <linux@...ck-us.net>
To: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Cc: lm-sensors@...sensors.org, Jean Delvare <khali@...ux-fr.org>,
linux-kernel@...r.kernel.org, Steve Hardy <shardy@...hat.com>
Subject: Re: [PATCH v5 1/2] hwmon: (ads7828) driver cleanup
On Wed, Oct 03, 2012 at 04:54:07PM -0400, Vivien Didelot wrote:
> As there is no reliable way to identify the chip, it is preferable to
> remove the detect callback, to avoid misdetection.
>
> Module parameters are not worth it here, so let's get rid of them and
> add an ads7828_platform_data structure instead.
>
> Clean the code by removing unused macros, fixing coding style issues,
> avoiding function prototypes and using convenient macros such as
> module_i2c_driver().
>
> Signed-off-by: Vivien Didelot <vivien.didelot@...oirfairelinux.com>
Applied to -next.
Thanks,
Guenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists