linux-kernel - Re: [Xen-devel] [PATCH] xen/xen_initial_domain: check that xen_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <506D5A53020000780009F8B7@nat28.tlf.novell.com>
Date:	Thu, 04 Oct 2012 08:43:47 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Stefano Stabellini" <Stefano.Stabellini@...citrix.com>
Cc:	"Ian Campbell" <Ian.Campbell@...rix.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>,
	"Konrad Rzeszutek Wilk" <konrad.wilk@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen/xen_initial_domain: check that
 xen_start_info is initialized

>>> On 03.10.12 at 19:08, Stefano Stabellini <Stefano.Stabellini@...citrix.com>
wrote:
> Since commit commit 4c071ee5268f7234c3d084b6093bebccc28cdcba ("arm:
> initial Xen support") PV on HVM guests can be xen_initial_domain.
> However PV on HVM guests might have an unitialized xen_start_info, so
> check before accessing its fields.
> 
> Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> Acked-by: Ian Campbell <Ian.Campbell@...rix.com>
> Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> 
> diff --git a/include/xen/xen.h b/include/xen/xen.h
> index 9a39ca5..e7101bb 100644
> --- a/include/xen/xen.h
> +++ b/include/xen/xen.h
> @@ -28,7 +28,7 @@ extern enum xen_domain_type xen_domain_type;
>  #include <asm/xen/hypervisor.h>
>  
>  #define xen_initial_domain()	(xen_domain() && \
> -				 xen_start_info->flags & SIF_INITDOMAIN)
> +				 xen_start_info && xen_start_info->flags & SIF_INITDOMAIN)
>  #else  /* !CONFIG_XEN_DOM0 */
>  #define xen_initial_domain()	(0)
>  #endif	/* CONFIG_XEN_DOM0 */

Didn't your other patch statically initialize it?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/