linux-kernel - Re: [PATCH] USB: input: wacom_sys.c: format OLED image in kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3b6f1beb0a048e1d02a7f684447c46b8.squirrel@webmail.firszt.eu>
Date:	Thu, 4 Oct 2012 09:15:19 +0100
From:	"Przemo Firszt" <przemo@...szt.eu>
To:	"Dmitry Torokhov" <dmitry.torokhov@...il.com>
Cc:	"Przemo Firszt" <przemo@...szt.eu>, rob@...dley.net,
	pinglinux@...il.com, linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org, linux-input@...r.kernel.org
Subject: Re: [PATCH] USB: input: wacom_sys.c: format OLED image in kernel


Dnia 4 Października 2012, 8:25 am, Cz, Dmitry Torokhov napisał(a):
> Hi Przemo,
Hi Dmitry,
>
> On Sun, Sep 09, 2012 at 03:37:18PM -0400, Przemo Firszt wrote:
>> This patch adds a new way of handling Wacom Intuos4 family OLEDs.
>> Previously the images had to be 'scrambled' by userland application. Now
>> the 'scrambling' is done in the kernel module, so user space can send
>> simple 64x32 pixels 4-bit grayscale (2 pixels per byte) 0,0 in top left
>> corner
>> images straight to a wacom OLED sysfs entry. An example:
>>
>> dd bs=1024 if=image_file \
>> of=/sys/bus/usb/drivers/wacom/[DevNo]/wacom_led/button[No]_formattedimg
>> \
>> count=1
>>
>> This patch greatly simplifies user space preparation of the image.
>> The raw image sysfs enties are still present to avoid breaking API.
>
> I do not not believe that we should add code to the kernel for tasks that
> can be just as easily performed in userspace.
>
> Thanks!
>
> --
> Dmitry
>
OK, thanks for the explanation!

-- 
Regards,
Przemo Firszt

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/