linux-kernel - Re: [PATCH 1/7] string: introduce helper to get base file name from given path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1349338789.13371.193.camel@smile>
Date:	Thu, 04 Oct 2012 11:19:49 +0300
From:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:	Nick Bowler <nbowler@...iptictech.com>
Cc:	Greg KH <gregkh@...uxfoundation.org>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, Joe Perches <joe@...ches.com>,
	YAMANE Toshiaki <yamanetoshi@...il.com>
Subject: Re: [PATCH 1/7] string: introduce helper to get base file name from
 given path

On Wed, 2012-10-03 at 14:39 -0400, Nick Bowler wrote: 
> On 2012-10-02 11:12 -0700, Greg KH wrote:
> > On Tue, Oct 02, 2012 at 08:52:05PM +0300, Andy Shevchenko wrote:
> > > On Tue, Oct 2, 2012 at 8:34 PM, Greg KH <gregkh@...uxfoundation.org> wrote:

[...]

> > Well, if you want your kbasename() function to work like the basename(3)
> > function, you need to properly handle a trailing '/' character.
> 
> Specifically, POSIX basename trims trailing '/' characters, so
> 
>   char foo[] = "a/string/with/trailing/slashes///";
>   basename(foo);
> 
> results in a string that compares equal to "slashes".  This implies that
> it must either modify the provided string or copy it somewhere else
> (POSIX admits either behaviour).
> 
> On the other hand, GNU basename does not trim trailing '/' characters
> and returns the empty string in this case.  It's truly unfortunate that
> glibc contains two different functions called basename, but regardless,
> the behaviour of the function in this proposal is certainly not
> unprecedented.
I fixed the description of the patch in v2.

-- 
Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/