linux-kernel - Re: [PATCH] btrfs ulist use rbtree instead

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20121004092644.GB14582@twin.jikos.cz>
Date:	Thu, 4 Oct 2012 11:26:44 +0200
From:	David Sterba <dave@...os.cz>
To:	Rock Lee <zimilo@...e-trick.com>
Cc:	chris.mason@...ionio.com, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] btrfs ulist use rbtree instead

> @@ -207,16 +266,23 @@ EXPORT_SYMBOL(ulist_add);
>   * end is reached. No guarantee is made with respect to the order in which
>   * the elements are returned. They might neither be returned in order of
>   * addition nor in ascending order.
> - * It is allowed to call ulist_add during an enumeration. Newly added items
> - * are guaranteed to show up in the running enumeration.
>   */
>  struct ulist_node *ulist_next(struct ulist *ulist, struct ulist_iterator *uiter)

Quick observation:

If there's code relying on the behaviour stated in the removed part of
the comment, it will break. Have you verified this is not the case?


david
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/