linux-kernel - RE: [PATCH 03/12] mmc: dw_mmc: fix building exynos driver as a module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <001d01cda22d$81a3b4f0$84eb1ed0$%jun@samsung.com>
Date:	Thu, 04 Oct 2012 21:40:59 +0900
From:	Seungwon Jeon <tgih.jun@...sung.com>
To:	'Will Newton' <will.newton@...il.com>,
	'Arnd Bergmann' <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arm@...nel.org, 'Chris Ball' <cjb@...top.org>,
	'Thomas Abraham' <thomas.abraham@...aro.org>,
	'Will Newton' <will.newton@...tec.com>,
	'Jaehoon Chung' <jh80.chung@...sung.com>,
	'Kyungmin Park' <kyungmin.park@...sung.com>,
	linux-mmc@...r.kernel.org
Subject: RE: [PATCH 03/12] mmc: dw_mmc: fix building exynos driver as a module

Monday, October 01, 2012, Will Newton <will.newton@...il.com> wrote:
> On Fri, Sep 28, 2012 at 10:36 PM, Arnd Bergmann <arnd@...db.de> wrote:
> > The MODULE_DEVICE_TABLE() entry in the dw_mmc_exynos driver
> > points to the wrong symbol which results in a link error
> > when building as a loadable module.
> >
> > Further, we get a warning about the driver_data being
> > marked constant, which requires annotating a few pointers
> > as const.
> >
> > Signed-off-by: Arnd Bergmann <arnd@...db.de>
> > Cc: Chris Ball <cjb@...top.org>
> > Cc: Thomas Abraham <thomas.abraham@...aro.org>
> > Cc: Will Newton <will.newton@...tec.com>
> > Cc: Jaehoon Chung <jh80.chung@...sung.com>
> > Cc: Seungwon Jeon <tgih.jun@...sung.com>
> > Cc: Kyungmin Park <kyungmin.park@...sung.com>
> > Cc: linux-mmc@...r.kernel.org
> > ---
> >  drivers/mmc/host/dw_mmc-exynos.c |    4 ++--
> >  drivers/mmc/host/dw_mmc-pltfm.c  |    2 +-
> >  drivers/mmc/host/dw_mmc-pltfm.h  |    2 +-
> >  drivers/mmc/host/dw_mmc.c        |    2 +-
> >  include/linux/mmc/dw_mmc.h       |    2 +-
> >  5 files changed, 6 insertions(+), 6 deletions(-)
> 
> This looks ok to me, but I'll let one of the Exynos guys ack those
> specific changes as I don't have the hardware.
> 
> There's already a patch for the dev_info warning in dw_mmc.c frm
> Seungwon Jeon, and it seems to me like a separate change but I don't
> really mind how it gets merged.

Looks good to me.
I don't mind it about including 'dev_info warning'.

Acked-by: Seungwon Jeon<tgih.jun@...sung.com>

> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/