linux-kernel - Re: [GIT PULL v2] Update LZO compression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20121004015122.GK16230@one.firstfloor.org>
Date:	Thu, 4 Oct 2012 03:51:22 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Andi Kleen <andi@...stfloor.org>,
	richard -rw- weinberger <richard.weinberger@...il.com>,
	"Markus F.X.J. Oberhumer" <markus@...rhumer.com>,
	linux-kernel@...r.kernel.org, chris.mason@...ionio.com,
	linux-btrfs@...r.kernel.org, Nitin Gupta <ngupta@...are.org>,
	Johannes Stezenbach <js@...21.net>
Subject: Re: [GIT PULL v2] Update LZO compression

> > > - Post the entire patch series to lkml for review (I'd like a cc please)
> > 
> > Already happened, multiple people reviewed and tested.
> 
> um, I would not consider "Looks ok to me from a quick look." and "I
> couldn't tell from the github view, but I assume you follow standard
> coding style." to indicate a rigorous code review!

Let's put it like this. LZO is mature widely used production software and 
Markus wrote and maintains it.  Essentially this is a release from him.

The main problem before with using his version directly was that it did 
not follow Linux coding standards, but that seems to be fixed now. It's 
also relatively simple and at least I didn't spot anything bad when I looked.

It was runtime tested by several people on different architectures.
If it was fuzzed so we can assume reasonably good security.

-Andi 

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/